Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 10805068: Enable new checkbox style by default (Linux/CrOS only) (Closed)

Created:
8 years, 5 months ago by Rick Byers
Modified:
8 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, Avi (use Gerrit)
Visibility:
Public.

Description

Enable new checkbox style by default (Linux/CrOS only) Also stop supporting non-square widgets, no other browser seems to do this and it exposes bugs in web pages. This is re-landing r147887 (reverted in r147899 due to breaking WebKit pixel tests). Temporarily suppresses the WebKit pixel test failures. I've reviewed each by hand to make sure the only change is what we expect with this style change. The baseline will be updated (and these expectations reverted) with the next WebKit roll. TBR=sky@chromium.org (identical to r147887 already reviewed) BUG=125773 TEST=A bunch of WebKit pixel tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148161

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment tweak and layout test expectation update #

Patch Set 3 : Merge with trunk #

Patch Set 4 : Two more expected layout test failures (ran only on linux_layout_rel bot for some reason) #

Patch Set 5 : Only expect pixel test failures on Linux (Windows/Mac style isn't changing) #

Patch Set 6 : Only expect pixel test failures on Linux (Windows/Mac style isn't changing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -29 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/native_theme/native_theme_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/native_theme/native_theme_base.cc View 1 3 chunks +15 lines, -11 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations.txt View 1 2 3 4 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Avi (use Gerrit)
https://chromiumcodereview.appspot.com/10805068/diff/1/ui/base/native_theme/native_theme_base.cc File ui/base/native_theme/native_theme_base.cc (right): https://chromiumcodereview.appspot.com/10805068/diff/1/ui/base/native_theme/native_theme_base.cc#newcode522 ui/base/native_theme/native_theme_base.cc:522: // Use the largest square rectangle that fits inside ...
8 years, 5 months ago (2012-07-23 19:50:01 UTC) #1
Rick Byers
Drew, do you want to review the change to webkit/tools/layout_tests/test_expectations.txt? The rest has already been ...
8 years, 5 months ago (2012-07-24 16:28:09 UTC) #2
Zhenyao Mo
8 years, 5 months ago (2012-07-24 18:33:46 UTC) #3
test_expectations.txt LGTM

Powered by Google App Engine
This is Rietveld 408576698