Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1849)

Unified Diff: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc

Issue 10805066: Pass the render process id to the FrameNavigationState. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
diff --git a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
index d9a6364db2aea2faf28126561965be9a8dbe1cc7..f56fd6e618e32cd7c91d57d757380be68ba99d77 100644
--- a/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
+++ b/chrome/browser/extensions/api/web_navigation/frame_navigation_state.cc
@@ -25,15 +25,19 @@ const char* kValidSchemes[] = {
} // namespace
// static
+FrameNavigationState::FrameID FrameNavigationState::kInvalidFrameID =
+ FrameNavigationState::FrameID(-1, -1);
+
+// static
bool FrameNavigationState::allow_extension_scheme_ = false;
FrameNavigationState::FrameNavigationState()
- : main_frame_id_(-1) {
+ : main_frame_id_(kInvalidFrameID) {
}
FrameNavigationState::~FrameNavigationState() {}
-bool FrameNavigationState::CanSendEvents(int64 frame_id) const {
+bool FrameNavigationState::CanSendEvents(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end() ||
@@ -56,7 +60,7 @@ bool FrameNavigationState::IsValidUrl(const GURL& url) const {
return false;
}
-void FrameNavigationState::TrackFrame(int64 frame_id,
+void FrameNavigationState::TrackFrame(FrameID frame_id,
const GURL& url,
bool is_main_frame,
bool is_error_page) {
@@ -77,7 +81,7 @@ void FrameNavigationState::TrackFrame(int64 frame_id,
frame_ids_.insert(frame_id);
}
-void FrameNavigationState::UpdateFrame(int64 frame_id, const GURL& url) {
+void FrameNavigationState::UpdateFrame(FrameID frame_id, const GURL& url) {
FrameIdToStateMap::iterator frame_state = frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end()) {
NOTREACHED();
@@ -86,13 +90,13 @@ void FrameNavigationState::UpdateFrame(int64 frame_id, const GURL& url) {
frame_state->second.url = url;
}
-bool FrameNavigationState::IsValidFrame(int64 frame_id) const {
+bool FrameNavigationState::IsValidFrame(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end());
}
-GURL FrameNavigationState::GetUrl(int64 frame_id) const {
+GURL FrameNavigationState::GetUrl(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
if (frame_state == frame_state_map_.end()) {
@@ -102,56 +106,56 @@ GURL FrameNavigationState::GetUrl(int64 frame_id) const {
return frame_state->second.url;
}
-bool FrameNavigationState::IsMainFrame(int64 frame_id) const {
- return main_frame_id_ != -1 && main_frame_id_ == frame_id;
+bool FrameNavigationState::IsMainFrame(FrameID frame_id) const {
+ return main_frame_id_ != kInvalidFrameID && main_frame_id_ == frame_id;
}
-int64 FrameNavigationState::GetMainFrameID() const {
+FrameNavigationState::FrameID FrameNavigationState::GetMainFrameID() const {
return main_frame_id_;
}
-void FrameNavigationState::SetErrorOccurredInFrame(int64 frame_id) {
+void FrameNavigationState::SetErrorOccurredInFrame(FrameID frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].error_occurred = true;
}
-bool FrameNavigationState::GetErrorOccurredInFrame(int64 frame_id) const {
+bool FrameNavigationState::GetErrorOccurredInFrame(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state == frame_state_map_.end() ||
frame_state->second.error_occurred);
}
-void FrameNavigationState::SetNavigationCompleted(int64 frame_id) {
+void FrameNavigationState::SetNavigationCompleted(FrameID frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_navigating = false;
}
-bool FrameNavigationState::GetNavigationCompleted(int64 frame_id) const {
+bool FrameNavigationState::GetNavigationCompleted(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state == frame_state_map_.end() ||
!frame_state->second.is_navigating);
}
-void FrameNavigationState::SetNavigationCommitted(int64 frame_id) {
+void FrameNavigationState::SetNavigationCommitted(FrameID frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_committed = true;
}
-bool FrameNavigationState::GetNavigationCommitted(int64 frame_id) const {
+bool FrameNavigationState::GetNavigationCommitted(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end() &&
frame_state->second.is_committed);
}
-void FrameNavigationState::SetIsServerRedirected(int64 frame_id) {
+void FrameNavigationState::SetIsServerRedirected(FrameID frame_id) {
DCHECK(frame_state_map_.find(frame_id) != frame_state_map_.end());
frame_state_map_[frame_id].is_server_redirected = true;
}
-bool FrameNavigationState::GetIsServerRedirected(int64 frame_id) const {
+bool FrameNavigationState::GetIsServerRedirected(FrameID frame_id) const {
FrameIdToStateMap::const_iterator frame_state =
frame_state_map_.find(frame_id);
return (frame_state != frame_state_map_.end() &&

Powered by Google App Engine
This is Rietveld 408576698