Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Unified Diff: chrome/browser/prerender/prerender_histograms.cc

Issue 10805063: Memory save on some OmniBox histograms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_histograms.cc
diff --git a/chrome/browser/prerender/prerender_histograms.cc b/chrome/browser/prerender/prerender_histograms.cc
index 415b19bace613c8fb5ddd23a73e1a7e592a1af80..a79c63741b3999fb2ff859ef30221b3f6ad69300 100644
--- a/chrome/browser/prerender/prerender_histograms.cc
+++ b/chrome/browser/prerender/prerender_histograms.cc
@@ -150,19 +150,17 @@ void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) {
void PrerenderHistograms::RecordPrerenderStarted(Origin origin) const {
if (OriginIsOmnibox(origin)) {
- UMA_HISTOGRAM_COUNTS(
+ UMA_HISTOGRAM_ENUMERATION(
dominich 2012/07/23 19:39:47 I would prefer any of these: - calling UMA_HISTOG
StringPrintf("Prerender.OmniboxPrerenderCount%s",
- PrerenderManager::GetModeString()).c_str(),
- 1);
+ PrerenderManager::GetModeString()), 1, 2);
}
}
void PrerenderHistograms::RecordUsedPrerender(Origin origin) const {
if (OriginIsOmnibox(origin)) {
- UMA_HISTOGRAM_COUNTS(
+ UMA_HISTOGRAM_ENUMERATION(
StringPrintf("Prerender.OmniboxNavigationsUsedPrerenderCount%s",
- PrerenderManager::GetModeString()).c_str(),
- 1);
+ PrerenderManager::GetModeString()), 1, 2);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698