Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 10805063: Memory save on some OmniBox histograms. (Closed)

Created:
8 years, 5 months ago by gavinp
Modified:
8 years, 5 months ago
Reviewers:
dominich
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Memory save on some OmniBox histograms. Two is the fewest number of allowed buckets. Should be fine for these. R=dominich@chromium.org BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147973

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/prerender/prerender_histograms.cc View 1 chunk +4 lines, -6 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
gavinp
Not a very big deal, but I was in the area and I think this ...
8 years, 5 months ago (2012-07-23 19:27:27 UTC) #1
dominich
lgtm http://codereview.chromium.org/10805063/diff/1/chrome/browser/prerender/prerender_histograms.cc File chrome/browser/prerender/prerender_histograms.cc (right): http://codereview.chromium.org/10805063/diff/1/chrome/browser/prerender/prerender_histograms.cc#newcode153 chrome/browser/prerender/prerender_histograms.cc:153: UMA_HISTOGRAM_ENUMERATION( I would prefer any of these: - ...
8 years, 5 months ago (2012-07-23 19:39:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10805063/1
8 years, 5 months ago (2012-07-23 19:44:23 UTC) #3
commit-bot: I haz the power
Try job failure for 10805063-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-23 19:52:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10805063/1
8 years, 5 months ago (2012-07-23 21:13:15 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 22:39:27 UTC) #6
Change committed as 147973

Powered by Google App Engine
This is Rietveld 408576698