Issue 10805057: Modified PolicyService to register observers by domain only, instead of domain and component.

Issue 10805057: Modified PolicyService to register observers by domain only, instead of domain and component. (Closed)

Created:
8 years, 5 months ago by Joao da Silva

Modified:
8 years, 5 months ago

Reviewers:
James Hawkins, Mattias Nissler (ping if slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Modified PolicyService to register observers by domain only, instead of domain and component. BUG=108999 TEST=Nothing breaks Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148082

Patch Set 2 : Fixed nit #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -61 lines)			Patch
M	chrome/browser/policy/configuration_policy_pref_store.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/policy_service.h	View		1 chunk	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/policy/policy_service.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl.h	View		3 chunks	+2 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl.cc	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	chrome/browser/policy/policy_service_impl_unittest.cc	View		5 chunks	+16 lines, -32 lines	0 comments	Download
M	chrome/browser/policy/policy_service_stub.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/policy_service_stub.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/policy_ui.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

@mnissler: please review @jhawkins: please do an owner review for ui/webui Thanks!

8 years, 5 months ago (2012-07-23 16:25:29 UTC) #1

Mattias Nissler (ping if slow)

lgtm http://codereview.chromium.org/10805057/diff/1/chrome/browser/policy/policy_service_stub.cc File chrome/browser/policy/policy_service_stub.cc (right): http://codereview.chromium.org/10805057/diff/1/chrome/browser/policy/policy_service_stub.cc#newcode15 chrome/browser/policy/policy_service_stub.cc:15: void PolicyServiceStub::AddObserver(PolicyDomain domain, Observer* observer) {} nit: I'd ...

8 years, 5 months ago (2012-07-23 16:47:31 UTC) #3

Joao da Silva

Thanks for the review! http://codereview.chromium.org/10805057/diff/1/chrome/browser/policy/policy_service_stub.cc File chrome/browser/policy/policy_service_stub.cc (right): http://codereview.chromium.org/10805057/diff/1/chrome/browser/policy/policy_service_stub.cc#newcode15 chrome/browser/policy/policy_service_stub.cc:15: void PolicyServiceStub::AddObserver(PolicyDomain domain, Observer* observer) ...

8 years, 5 months ago (2012-07-24 09:39:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10805057/5002

8 years, 5 months ago (2012-07-24 09:40:12 UTC) #5

Change committed as 148082

Expand Messages | Collapse Messages