Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/performance_monitor/metric_details.cc

Issue 10805050: Chrome Performance Monitor: MetricDetails refactor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced + nit. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/performance_monitor/metric_details.cc
diff --git a/chrome/browser/performance_monitor/metric_details.cc b/chrome/browser/performance_monitor/metric_details.cc
index b8754ed6530e13af90aeadc144ebfc03496eacb0..878a11c5bed5e9da12196890f3d40d44e590d4b9 100644
--- a/chrome/browser/performance_monitor/metric_details.cc
+++ b/chrome/browser/performance_monitor/metric_details.cc
@@ -12,29 +12,28 @@ namespace {
// Keep this array synced with MetricTypes in the header file.
// TODO(mtytel): i18n.
-const char* kMetricTypeNames[] = {
- kSampleMetricName
+const MetricDetails kMetricDetailsList[] = {
+ {
+ kMetricCPUUsageName,
+ kMetricCPUUsageDescription,
+ kMetricCPUUsageUnits,
+ kMetricCPUUsageTickSize,
+ },
+ {
+ kMetricPrivateMemoryUsageName,
+ kMetricPrivateMemoryUsageDescription,
+ kMetricPrivateMemoryUsageUnits,
+ kMetricPrivateMemoryUsageTickSize
+ },
};
-COMPILE_ASSERT(ARRAYSIZE_UNSAFE(kMetricTypeNames) == METRIC_NUMBER_OF_METRICS,
+COMPILE_ASSERT(ARRAYSIZE_UNSAFE(kMetricDetailsList) == METRIC_NUMBER_OF_METRICS,
metric_names_incorrect_size);
} // namespace
-const char* MetricTypeToString(MetricType metric_type) {
+const MetricDetails* GetMetricDetails(MetricType metric_type) {
DCHECK_GT(METRIC_NUMBER_OF_METRICS, metric_type);
- return kMetricTypeNames[metric_type];
-}
-
-MetricDetails::MetricDetails() {
-}
-
-MetricDetails::MetricDetails(const std::string& metric_name,
- const std::string& metric_description)
- : name(metric_name),
- description(metric_description) {
-}
-
-MetricDetails::~MetricDetails() {
+ return &kMetricDetailsList[metric_type];
}
} // namespace performance_monitor
« no previous file with comments | « chrome/browser/performance_monitor/metric_details.h ('k') | chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698