Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3851)

Unified Diff: chrome/browser/performance_monitor/constants.h

Issue 10805050: Chrome Performance Monitor: MetricDetails refactor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Synced + nit. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/performance_monitor/constants.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/performance_monitor/constants.h
diff --git a/chrome/browser/performance_monitor/constants.h b/chrome/browser/performance_monitor/constants.h
index c8382eb02da72336c4335957a3d41648f3592e8a..a3455b0a4e83dbf08ed3049f5d1706da0110e88f 100644
--- a/chrome/browser/performance_monitor/constants.h
+++ b/chrome/browser/performance_monitor/constants.h
@@ -7,18 +7,24 @@
namespace performance_monitor {
-// TODO(chebert): i18n
+// TODO(chebert): i18n on all constants.
extern const char kMetricNotFoundError[];
// Any metric that is not associated with a specific activity will use this as
// its activity.
extern const char kProcessChromeAggregate[];
-// When you add a metric type, make sure to edit Database::InitMetricDetails
-// and add an entry to the MericType enum.
-// TODO(mwrosen): When you make real metrics, delete the sample metric.
-extern const char kSampleMetricDescription[];
-extern const char kSampleMetricName[];
+// Metrics keys for statistics gathering.
+extern const char kMetricCPUUsageName[];
+extern const char kMetricCPUUsageDescription[];
+extern const char kMetricCPUUsageUnits[];
+extern const double kMetricCPUUsageTickSize;
+
+extern const char kMetricPrivateMemoryUsageName[];
+extern const char kMetricPrivateMemoryUsageDescription[];
+extern const char kMetricPrivateMemoryUsageUnits[];
+extern const double kMetricPrivateMemoryUsageTickSize;
+
extern const char kStateChromeVersion[];
} // namespace performance_monitor
« no previous file with comments | « no previous file | chrome/browser/performance_monitor/constants.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698