Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 10805047: Move WebDialogView to ui/views/controls/webview. (Closed)

Created:
8 years, 5 months ago by mazda
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Move WebDialogView to ui/views/controls/webview. Also move WebDialogView into views namespace. BUG=124222, 125846 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147876

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -477 lines) Patch
M chrome/browser/ui/views/chrome_web_dialog_view.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/views/web_dialog_view.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/ui/views/web_dialog_view.cc View 1 chunk +0 lines, -320 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
A + ui/views/controls/webview/web_dialog_view.h View 1 5 chunks +10 lines, -8 lines 0 comments Download
A + ui/views/controls/webview/web_dialog_view.cc View 1 3 chunks +5 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mazda
Scott, Could you review this change? I'd like to use WebDialogView from KeyboardOverlayDialogView, which will ...
8 years, 5 months ago (2012-07-20 22:17:21 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-23 15:28:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10805047/3013
8 years, 5 months ago (2012-07-23 16:04:21 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 17:37:40 UTC) #4
Change committed as 147876

Powered by Google App Engine
This is Rietveld 408576698