Issue 10805037: Fix the svn version check issue, append '--quiet' to get svn version string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10805037: Fix the svn version check issue, append '--quiet' to get svn version string. (Closed)

Created:
8 years, 5 months ago by Shouqun Liu

Modified:
8 years, 5 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
https://git.chromium.org/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Fix the svn version check issue, append '--quiet' to get svn version string. In some enviroments (eg, OSX zh_CN), use 'svn --version' and splitting string may get error version string. Use 'svn --version --quiet' to do stable svn version check, which directly returns version string such as '1.7.0'. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147670

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -17 lines)			Patch
	M	scm.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/gclient_scm_test.py	View		8 chunks	+16 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Shouqun Liu

Hi, this patch fix an issue of checking svn version in some localized OS/svn, using ...

8 years, 5 months ago (2012-07-20 07:56:35 UTC) #1

M-A Ruel

Verified it works with svn 1.6.12. We don't really support 1.5 anymore so it should ...

8 years, 5 months ago (2012-07-20 17:13:46 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10805037/1

8 years, 5 months ago (2012-07-20 17:13:52 UTC) #3

Change committed as 147670

Expand Messages | Collapse Messages