Update extract_action.py for ChromeOS IME

Update extract_action.py for ChromeOS IME

BUG=138498
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147938

[kochi, 2012-07-23 04:57:26]

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/chromeactions.txt
File chrome/tools/chromeactions.txt (right):

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/chromeactions....
chrome/tools/chromeactions.txt:34:
0x89ee0fa8efbf345c	AboutFlags_print-setting-reset
This looks unrelated to this CL - probably the author forgot
to update this file when he added this.

Please include him in this review CL to let him know.

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/extract_action...
File chrome/tools/extract_actions.py (right):

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/extract_action...
chrome/tools/extract_actions.py:80: #
chrome/browser/chromeos/input_method/input_methods.txt in the Chrome OS tree,
s/Chrome OS/Chrome/

[Seigo Nonaka, 2012-07-23 05:42:40]

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/chromeactions.txt
File chrome/tools/chromeactions.txt (right):

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/chromeactions....
chrome/tools/chromeactions.txt:34:
0x89ee0fa8efbf345c	AboutFlags_print-setting-reset
Sure, will do.
On 2012/07/23 04:57:27, Takayoshi Kochi wrote:
> This looks unrelated to this CL - probably the author forgot
> to update this file when he added this.
> 
> Please include him in this review CL to let him know.

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/extract_action...
File chrome/tools/extract_actions.py (right):

http://codereview.chromium.org/10805035/diff/3002/chrome/tools/extract_action...
chrome/tools/extract_actions.py:80: #
chrome/browser/chromeos/input_method/input_methods.txt in the Chrome OS tree,
On 2012/07/23 04:57:27, Takayoshi Kochi wrote:
> s/Chrome OS/Chrome/

Done.

[Seigo Nonaka, 2012-07-23 05:56:40]

Hi Albert, Yusuke,

I update the extract_action.py and chromeaction.txt.
However I found some entries which are not introduced by my change.
Seems to forget to update chromeaction.txt by running the extract_action.py
script.
Could you check the following entries are expected?

Albert:
34 0x89ee0fa8efbf345c      AboutFlags_print-setting-reset

Yusuke:
55 0x125f05329e660307      Accel_KeyboardBrightnessDown_F6
56 0xcdd268156ab80bb1      Accel_KeyboardBrightnessUp_F7

Thank you.
Seigo

[kochi, 2012-07-23 06:05:21]

lgtm

[Yusuke Sato, 2012-07-23 06:07:55]

LGTM. I recently added them.

On 2012/07/23 05:56:40, Seigo Nonaka wrote:
> Hi Albert, Yusuke,
> 
> I update the extract_action.py and chromeaction.txt.
> However I found some entries which are not introduced by my change.
> Seems to forget to update chromeaction.txt by running the extract_action.py
> script.
> Could you check the following entries are expected?
> 
> Albert:
> 34 0x89ee0fa8efbf345c      AboutFlags_print-setting-reset
> 
> Yusuke:
> 55 0x125f05329e660307      Accel_KeyboardBrightnessDown_F6
> 56 0xcdd268156ab80bb1      Accel_KeyboardBrightnessUp_F7
> 
> Thank you.
> Seigo

[Albert Bodenhamer, 2012-07-23 16:17:45]

lgtm

http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions.txt
File chrome/tools/chromeactions.txt (right):

http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions....
chrome/tools/chromeactions.txt:34:
0x89ee0fa8efbf345c	AboutFlags_print-setting-reset
print-setting-reset will likely be going away soon.  I'm not sure if it's worth
referencing it here.

[Yusuke Sato, 2012-07-23 17:23:33]

one more comment: can you add some instructions to input_methods.txt so that
developers can remember that they have to update the python script?

On 2012/07/23 16:17:45, Albert Bodenhamer wrote:
> lgtm
> 
>
http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions.txt
> File chrome/tools/chromeactions.txt (right):
> 
>
http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions....
> chrome/tools/chromeactions.txt:34:
> 0x89ee0fa8efbf345c	AboutFlags_print-setting-reset
> print-setting-reset will likely be going away soon.  I'm not sure if it's
worth
> referencing it here.

[Seigo Nonaka, 2012-07-23 18:29:28]

Albert:
Sure, please update the chromeactions.txt after the entry is removed.

Yusuke:
I tried to update input_methods.txt at the same time, but it contains obsolete
descriptions and I need investigation for getting latest one.
To track this issue, I filed a bug(http://crbug.com/138498) and continue to work
for them.

Thanks
Seigo.

On 2012/07/23 17:23:33, Yusuke Sato wrote:
> one more comment: can you add some instructions to input_methods.txt so that
> developers can remember that they have to update the python script?
> 
> On 2012/07/23 16:17:45, Albert Bodenhamer wrote:
> > lgtm
> > 
> >
>
http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions.txt
> > File chrome/tools/chromeactions.txt (right):
> > 
> >
>
http://codereview.chromium.org/10805035/diff/3004/chrome/tools/chromeactions....
> > chrome/tools/chromeactions.txt:34:
> > 0x89ee0fa8efbf345c	AboutFlags_print-setting-reset
> > print-setting-reset will likely be going away soon.  I'm not sure if it's
> worth
> > referencing it here.

[commit-bot: I haz the power, 2012-07-23 18:29:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/10805035/3004

[commit-bot: I haz the power, 2012-07-23 20:58:02]

Change committed as 147938