Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2441)

Unified Diff: chrome/browser/automation/automation_provider.cc

Issue 10805020: Kill DownloadItem::IsOtr() (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/automation/automation_provider.cc
diff --git a/chrome/browser/automation/automation_provider.cc b/chrome/browser/automation/automation_provider.cc
index 31acc47ea4993aa67972f55ffb700c2f36d5b804..e3f5cb123d59f5966c28cc981eee26b6bd9e2fc9 100644
--- a/chrome/browser/automation/automation_provider.cc
+++ b/chrome/browser/automation/automation_provider.cc
@@ -300,7 +300,7 @@ int AutomationProvider::GetIndexForNavigationController(
// TODO(phajdan.jr): move to TestingAutomationProvider.
DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
- const DownloadItem* download) {
+ const DownloadItem* download, bool incognito) {
std::map<DownloadItem::DownloadState, std::string> state_to_string;
state_to_string[DownloadItem::IN_PROGRESS] = std::string("IN_PROGRESS");
state_to_string[DownloadItem::CANCELLED] = std::string("CANCELLED");
@@ -325,7 +325,7 @@ DictionaryValue* AutomationProvider::GetDictionaryFromDownloadItem(
dl_item_value->SetBoolean("open_when_complete",
download->GetOpenWhenComplete());
dl_item_value->SetBoolean("is_temporary", download->IsTemporary());
- dl_item_value->SetBoolean("is_otr", download->IsOtr()); // incognito
+ dl_item_value->SetBoolean("is_otr", incognito);
dl_item_value->SetString("state", state_to_string[download->GetState()]);
dl_item_value->SetString("safety_state",
safety_state_to_string[download->GetSafetyState()]);
« no previous file with comments | « chrome/browser/automation/automation_provider.h ('k') | chrome/browser/automation/automation_provider_observers.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698