Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 10805019: Add net library for content unit test and enable related test cases on Android. (Closed)

Created:
8 years, 5 months ago by Shouqun Liu
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, jam, sky, nilesh
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add net library for content unit test and enable related test cases on Android. BUG= TEST=content_unittests_apk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147647

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add dependency to net_java #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M build/android/gtest_filter/content_unittests_disabled View 1 chunk +0 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M content/test/run_all_unittests.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Shouqun Liu
Hi, this patch fix failed test cases SavePackageTest.* which depend on net::GetMimeTypeFromExtension, net::GetMimeTypeFromExtension in Android ...
8 years, 5 months ago (2012-07-20 02:45:34 UTC) #1
nilesh
http://codereview.chromium.org/10805019/diff/1007/content/content_tests.gypi File content/content_tests.gypi (right): http://codereview.chromium.org/10805019/diff/1007/content/content_tests.gypi#newcode689 content/content_tests.gypi:689: 'content_unittests', You should add an explicit dependency on the ...
8 years, 5 months ago (2012-07-20 03:01:15 UTC) #2
Shouqun Liu
yes, add the dependency to net.gyp:net_java http://codereview.chromium.org/10805019/diff/1007/content/content_tests.gypi File content/content_tests.gypi (right): http://codereview.chromium.org/10805019/diff/1007/content/content_tests.gypi#newcode689 content/content_tests.gypi:689: 'content_unittests', On 2012/07/20 ...
8 years, 5 months ago (2012-07-20 03:12:03 UTC) #3
nilesh
LGTM. Please wait for OWNERS approval.
8 years, 5 months ago (2012-07-20 04:51:38 UTC) #4
jam
lgtm
8 years, 5 months ago (2012-07-20 06:05:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10805019/7006
8 years, 5 months ago (2012-07-20 11:48:51 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 13:08:42 UTC) #7
Change committed as 147647

Powered by Google App Engine
This is Rietveld 408576698