Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10805015: Move browsing_data_helper files into a separate directory. (Closed)

Created:
8 years, 5 months ago by markusheintz_
Modified:
8 years, 5 months ago
CC:
chromium-reviews, michaeln
Visibility:
Public.

Description

Move browsing_data_helper files into a separate directory. BUG=121862 TEST=existing unit_tests TBR=eroman@chromium.org,sky@chromium.org,erg@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147504

Patch Set 1 #

Patch Set 2 : " #

Patch Set 3 : " #

Patch Set 4 : " #

Patch Set 5 : " #

Patch Set 6 : " #

Total comments: 2

Patch Set 7 : Address comments (Jochen); Move quota_helper and remover #

Patch Set 8 : fix cros and win build; fix typos #

Patch Set 9 : Fix chrome_frame build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -8620 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/automation_provider_observers.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/browsing_data/OWNERS View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_appcache_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_appcache_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_appcache_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_cookie_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_cookie_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_database_helper.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_database_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_file_system_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_file_system_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_file_system_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_helper_browsertest.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_indexed_db_helper.h View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_indexed_db_helper.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_indexed_db_helper_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_indexed_db_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_local_storage_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_local_storage_helper.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_local_storage_helper_browsertest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_local_storage_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_quota_helper.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_quota_helper.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_quota_helper_impl.h View 1 2 3 4 5 6 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_quota_helper_impl.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_quota_helper_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_remover.h View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_remover.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/browsing_data_server_bound_cert_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/local_data_container.h View 1 2 3 4 5 6 7 2 chunks +11 lines, -11 lines 0 comments Download
A + chrome/browser/browsing_data/local_data_container.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_appcache_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_appcache_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_cookie_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_database_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_database_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_file_system_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_file_system_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_indexed_db_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_local_storage_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_quota_helper.h View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_quota_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_server_bound_cert_helper.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/browsing_data/mock_browsing_data_server_bound_cert_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/browsing_data_appcache_helper.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/browsing_data_appcache_helper.cc View 1 1 chunk +0 lines, -156 lines 0 comments Download
D chrome/browser/browsing_data_appcache_helper_unittest.cc View 1 1 chunk +0 lines, -122 lines 0 comments Download
D chrome/browser/browsing_data_cookie_helper.h View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/browsing_data_cookie_helper.cc View 1 chunk +0 lines, -230 lines 0 comments Download
M chrome/browser/browsing_data_cookie_helper_unittest.cc View 1 1 chunk +0 lines, -233 lines 0 comments Download
D chrome/browser/browsing_data_database_helper.h View 1 1 chunk +0 lines, -167 lines 0 comments Download
D chrome/browser/browsing_data_database_helper.cc View 1 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/browsing_data_database_helper_browsertest.cc View 1 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/browsing_data_database_helper_unittest.cc View 1 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/browsing_data_file_system_helper.h View 1 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/browsing_data_file_system_helper.cc View 1 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/browser/browsing_data_file_system_helper_unittest.cc View 1 1 chunk +0 lines, -318 lines 0 comments Download
D chrome/browser/browsing_data_helper.h View 1 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/browsing_data_helper.cc View 1 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/browsing_data_helper_browsertest.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/browsing_data_helper_unittest.cc View 1 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/browsing_data_indexed_db_helper.h View 1 1 chunk +0 lines, -145 lines 0 comments Download
D chrome/browser/browsing_data_indexed_db_helper.cc View 1 1 chunk +0 lines, -263 lines 0 comments Download
D chrome/browser/browsing_data_indexed_db_helper_browsertest.cc View 1 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/browsing_data_indexed_db_helper_unittest.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/browsing_data_local_storage_helper.h View 1 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/browser/browsing_data_local_storage_helper.cc View 1 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/browser/browsing_data_local_storage_helper_browsertest.cc View 1 1 chunk +0 lines, -191 lines 0 comments Download
D chrome/browser/browsing_data_local_storage_helper_unittest.cc View 1 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/browsing_data_quota_helper.h View 1 2 3 4 5 6 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/browser/browsing_data_quota_helper.cc View 1 2 3 4 5 6 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/browsing_data_quota_helper_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -77 lines 0 comments Download
M chrome/browser/browsing_data_quota_helper_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/browser/browsing_data_quota_helper_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -209 lines 0 comments Download
D chrome/browser/browsing_data_remover.h View 1 2 3 4 5 6 1 chunk +0 lines, -367 lines 0 comments Download
M chrome/browser/browsing_data_remover.cc View 1 2 3 4 5 6 1 chunk +0 lines, -887 lines 0 comments Download
M chrome/browser/browsing_data_remover_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1156 lines 0 comments Download
D chrome/browser/browsing_data_server_bound_cert_helper.h View 1 1 chunk +0 lines, -91 lines 0 comments Download
D chrome/browser/browsing_data_server_bound_cert_helper.cc View 1 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/browser/browsing_data_server_bound_cert_helper_unittest.cc View 1 1 chunk +0 lines, -159 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/local_shared_objects_container.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/content_settings/tab_specific_content_settings.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/cookies_tree_model.h View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/cookies_tree_model.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/cookies_tree_model_unittest.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/browsing_data/browsing_data_test.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/local_data_container.h View 1 2 1 chunk +0 lines, -141 lines 0 comments Download
M chrome/browser/local_data_container.cc View 1 2 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/browser/mock_browsing_data_appcache_helper.h View 1 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/mock_browsing_data_appcache_helper.cc View 1 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/mock_browsing_data_cookie_helper.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/mock_browsing_data_cookie_helper.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/mock_browsing_data_database_helper.h View 1 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/mock_browsing_data_database_helper.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/mock_browsing_data_file_system_helper.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/mock_browsing_data_file_system_helper.cc View 1 1 chunk +0 lines, -61 lines 0 comments Download
D chrome/browser/mock_browsing_data_indexed_db_helper.h View 1 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/mock_browsing_data_indexed_db_helper.cc View 1 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/mock_browsing_data_local_storage_helper.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/mock_browsing_data_local_storage_helper.cc View 1 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/mock_browsing_data_quota_helper.h View 1 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/mock_browsing_data_quota_helper.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/mock_browsing_data_server_bound_cert_helper.h View 1 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/mock_browsing_data_server_bound_cert_helper.cc View 1 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/collected_cookies_mac.mm View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/cocoa/content_settings/cookie_details.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/collected_cookies_gtk.cc View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_chrome_cookie_view.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/indexed_db_info_view.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/local_storage_info_view.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enterprise_oauth_enrollment_screen_handler.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/pack_extension_handler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/clear_browser_data_handler.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options2/clear_browser_data_handler.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/cookies_view_handler.cc View 1 2 3 4 5 6 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options2/web_intents_settings_handler.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 2 chunks +24 lines, -24 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 3 chunks +30 lines, -30 lines 0 comments Download
M chrome_frame/delete_chrome_history.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
markusheintz_
Please review this CL. Thanks a lot.
8 years, 5 months ago (2012-07-19 01:23:58 UTC) #1
markusheintz_
On 2012/07/19 01:23:58, markusheintz_ wrote: > Please review this CL. Thanks a lot. FYI the ...
8 years, 5 months ago (2012-07-19 01:33:54 UTC) #2
jochen (gone - plz use gerrit)
lgtm, assuming you just moved the files and updated include paths https://chromiumcodereview.appspot.com/10805015/diff/11121/chrome/browser/browsing_data/OWNERS File chrome/browser/browsing_data/OWNERS (right): ...
8 years, 5 months ago (2012-07-19 07:40:03 UTC) #3
markusheintz_
@Jochen: Yep I'm only moving files in this CL. Thanks for the review. Added reviewers ...
8 years, 5 months ago (2012-07-19 10:35:39 UTC) #4
jochen (gone - plz use gerrit)
since it's only updating paths in the include files, you can TBR the owners
8 years, 5 months ago (2012-07-19 10:48:21 UTC) #5
Nikita (slow)
chromeos/login lgtm
8 years, 5 months ago (2012-07-19 13:09:14 UTC) #6
James Hawkins
lgtm
8 years, 5 months ago (2012-07-19 14:00:39 UTC) #7
markusheintz_
@Jochen: Thank for the tip. TBR'ing OWNERS
8 years, 5 months ago (2012-07-19 14:52:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10805015/25001
8 years, 5 months ago (2012-07-19 14:52:38 UTC) #9
commit-bot: I haz the power
Try job failure for 10805015-25001 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-19 15:40:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/10805015/6120
8 years, 5 months ago (2012-07-19 17:58:52 UTC) #11
eroman
net_internals LGTM
8 years, 5 months ago (2012-07-19 18:40:34 UTC) #12
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 19:22:50 UTC) #13 
Change committed as 147504

Powered by Google App Engine
This is Rietveld 408576698