Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10805006: Make message pass in Android testing (Closed)

Created:
8 years, 5 months ago by haitao.feng
Modified:
8 years, 5 months ago
Reviewers:
ulan, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make message pass in Android testing Committed: https://code.google.com/p/v8/source/detail?r=12123

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/message/testcfg.py View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
haitao.feng
The "Error returned by test" is introduced by android-run.py when running *.JS in d8 when ...
8 years, 5 months ago (2012-07-18 11:14:48 UTC) #1
Jakob Kummerow
8 years, 5 months ago (2012-07-18 11:52:14 UTC) #2
LGTM with nit.

I'll fix it for you and land this CL.

Please remember to break lines at 80 columns if at all possible.

https://chromiumcodereview.appspot.com/10805006/diff/1/test/message/testcfg.py
File test/message/testcfg.py (right):

https://chromiumcodereview.appspot.com/10805006/diff/1/test/message/testcfg.p...
test/message/testcfg.py:46: else: return str.startswith('==') or
str.startswith('**') or str.startswith('Error')
nit: long line

Powered by Google App Engine
This is Rietveld 408576698