Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1117)

Unified Diff: sync/internal_api/public/sync_manager.h

Issue 10805002: [Sync] Enable adding notifier observers from ProfileSyncService (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/public/sync_manager.h
diff --git a/sync/internal_api/public/sync_manager.h b/sync/internal_api/public/sync_manager.h
index f1b23ce25a19ca332ce9867cca8481a368a5fa18..f36b8ec8b49e1752976fc2849acfc134f9a85bf7 100644
--- a/sync/internal_api/public/sync_manager.h
+++ b/sync/internal_api/public/sync_manager.h
@@ -22,36 +22,31 @@
#include "sync/internal_api/public/engine/sync_status.h"
#include "sync/internal_api/public/util/report_unrecoverable_error_function.h"
#include "sync/internal_api/public/util/weak_handle.h"
+#include "sync/notifier/invalidation_util.h"
#include "sync/protocol/sync_protocol_error.h"
+namespace sync_pb {
+class EncryptedData;
+} // namespace sync_pb
+
namespace syncer {
msw 2012/08/03 05:14:21 nit: if the syncer namespace contains more than ju
+class BaseTransaction;
class Encryptor;
struct Experiments;
class ExtensionsActivityMonitor;
+class HttpPostProviderFactory;
class InternalComponentsFactory;
class JsBackend;
class JsEventHandler;
+class SyncNotifier;
+class SyncNotifierObserver;
class SyncScheduler;
class UnrecoverableErrorHandler;
+struct UserShare;
namespace sessions {
class SyncSessionSnapshot;
} // namespace sessions
-} // namespace syncer
-
-namespace syncer {
-class SyncNotifier;
-} // namespace syncer
-
-namespace sync_pb {
-class EncryptedData;
-} // namespace sync_pb
-
-namespace syncer {
-
-class BaseTransaction;
-class HttpPostProviderFactory;
-struct UserShare;
// Used by SyncManager::OnConnectionStatusChange().
enum ConnectionStatus {
@@ -411,6 +406,11 @@ class SyncManager {
virtual void UpdateEnabledTypes(
const ModelTypeSet& enabled_types) = 0;
+ // Forwards to the underlying notifier (see
+ // SyncNotifier::UpdateRegisteredIds()).
+ virtual void UpdateRegisteredInvalidationIds(
+ SyncNotifierObserver* handler, const ObjectIdSet& ids) = 0;
msw 2012/08/03 05:14:21 The style guide dictates that these parameters sho
+
// Put the syncer in normal mode ready to perform nudges and polls.
virtual void StartSyncingNormally(
const ModelSafeRoutingInfo& routing_info) = 0;

Powered by Google App Engine
This is Rietveld 408576698