Issue 10804027: Track how much time the compiler thread spends doing useful work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10804027: Track how much time the compiler thread spends doing useful work. (Closed)

Created:
8 years, 5 months ago by sanjoy

Modified:
8 years, 5 months ago

Reviewers:
danno, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Track how much time the compiler thread spends doing useful work. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12152

Patch Set 1 : #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -1 line)			Patch
	M	src/optimizing-compiler-thread.h	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	src/optimizing-compiler-thread.cc	View		3 chunks	+20 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sanjoy

The compiler thread does useful work only 0.5% of the time, which I think is ...

8 years, 5 months ago (2012-07-19 19:08:50 UTC) #1

Yang

8 years, 5 months ago (2012-07-20 08:21:38 UTC) #2

LGTM. There is just one comment about your previous CL that you could change
now.

http://codereview.chromium.org/10804027/diff/3001/src/optimizing-compiler-thr...
File src/optimizing-compiler-thread.cc (right):

http://codereview.chromium.org/10804027/diff/3001/src/optimizing-compiler-thr...
src/optimizing-compiler-thread.cc:72: (void) status;
Change this to USE(status)

Expand Messages | Collapse Messages