Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 10804020: Introduce runtime.onSuspendCanceled() event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: respond to comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.h
diff --git a/chrome/browser/extensions/extension_process_manager.h b/chrome/browser/extensions/extension_process_manager.h
index eea12952a7f17e03f172bddf37a65fbe880fdebb..03a546baba53456ced46cff501be61dc98bf6f17 100644
--- a/chrome/browser/extensions/extension_process_manager.h
+++ b/chrome/browser/extensions/extension_process_manager.h
@@ -113,8 +113,12 @@ class ExtensionProcessManager : public content::NotificationObserver {
// the count of how many outstanding "things" are keeping the page alive.
// When this reaches 0, we will begin the process of shutting down the page.
// "Things" include pending events, resource loads, and API calls.
+ // The |cancel_suspend| option defaults to false and indicates whether
benwells 2012/07/20 10:57:00 I'd prefer |cancel_suspend| to be a non-optional e
+ // incrementing the keepalive count should prevent it from being suspended.
int GetLazyKeepaliveCount(const extensions::Extension* extension);
int IncrementLazyKeepaliveCount(const extensions::Extension* extension);
+ int IncrementLazyKeepaliveCount(const extensions::Extension* extension,
+ bool cancel_suspend);
int DecrementLazyKeepaliveCount(const extensions::Extension* extension);
void IncrementLazyKeepaliveCountForView(
@@ -185,7 +189,8 @@ class ExtensionProcessManager : public content::NotificationObserver {
void OnLazyBackgroundPageIdle(const std::string& extension_id,
int sequence_id);
void OnLazyBackgroundPageActive(const std::string& extension_id);
- void CloseLazyBackgroundPageNow(const std::string& extension_id);
+ void CloseLazyBackgroundPageNow(const std::string& extension_id,
+ int sequence_id);
// Updates a potentially-registered RenderViewHost once it has been
// associated with a WebContents. This allows us to gather information that

Powered by Google App Engine
This is Rietveld 408576698