Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 10804020: Introduce runtime.onSuspendCanceled() event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.h
diff --git a/chrome/browser/extensions/extension_process_manager.h b/chrome/browser/extensions/extension_process_manager.h
index 332fcda71c1b72966751243967f2762b4a9446c1..80e8e5ace9b9aee110232e61fd1780953e426ee7 100644
--- a/chrome/browser/extensions/extension_process_manager.h
+++ b/chrome/browser/extensions/extension_process_manager.h
@@ -36,10 +36,6 @@ class Extension;
// track of split-mode extensions only.
class ExtensionProcessManager : public content::NotificationObserver {
public:
- enum ShouldCancelSuspend {
- CANCEL_SUSPEND,
- DONT_CANCEL_SUSPEND
- };
typedef std::set<ExtensionHost*> ExtensionHostSet;
typedef ExtensionHostSet::const_iterator const_iterator;
@@ -117,11 +113,8 @@ class ExtensionProcessManager : public content::NotificationObserver {
// the count of how many outstanding "things" are keeping the page alive.
// When this reaches 0, we will begin the process of shutting down the page.
// "Things" include pending events, resource loads, and API calls.
- // The |cancel_suspend| option defaults to false and indicates whether
- // incrementing the keepalive count should prevent it from being suspended.
int GetLazyKeepaliveCount(const extensions::Extension* extension);
- int IncrementLazyKeepaliveCount(const extensions::Extension* extension,
- ShouldCancelSuspend should_cancel_suspend);
+ int IncrementLazyKeepaliveCount(const extensions::Extension* extension);
int DecrementLazyKeepaliveCount(const extensions::Extension* extension);
void IncrementLazyKeepaliveCountForView(
@@ -139,6 +132,10 @@ class ExtensionProcessManager : public content::NotificationObserver {
void OnNetworkRequestStarted(content::RenderViewHost* render_view_host);
void OnNetworkRequestDone(content::RenderViewHost* render_view_host);
+ // Prevents |extension|'s background page from being closed and sends the
+ // onSuspendCanceled() event to it.
+ void CancelSuspend(const extensions::Extension* extension);
+
protected:
explicit ExtensionProcessManager(Profile* profile);

Powered by Google App Engine
This is Rietveld 408576698