Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 10804004: Remove the deprecated PeerConnection that uses the ROAP protocol. (Closed)

Created:
8 years, 5 months ago by perkj_chrome
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Nirnimesh, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, anantha, darin-cc_chromium.org, dyu1, dennis_jeffrey
Visibility:
Public.

Description

Remove the deprecated PeerConnection supporting the ROAP protocol. Note that JSEP 00 is still supported and we are adding support for JSEP01. TEST= Run content unit tests and ./chrome/test/functional/webrtc_call.py apprtc.appspot.com is also a nice page to try out. Start chrome with the enable-peer-connection flag. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148548

Patch Set 1 #

Patch Set 2 : Fix line length in webrtc_call.py #

Patch Set 3 : Updated to latest code base. #

Patch Set 4 : Removed trailing whitespace in webrtc.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -599 lines) Patch
D chrome/test/data/webrtc/roap_call.js View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/test/data/webrtc/webrtc_roap_test.html View 1 chunk +0 lines, -26 lines 0 comments Download
M chrome/test/functional/webrtc_call.py View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_dependency_factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 2 3 chunks +0 lines, -18 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/mock_media_stream_dependency_factory.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D content/renderer/media/peer_connection_handler.h View 1 chunk +0 lines, -68 lines 0 comments Download
D content/renderer/media/peer_connection_handler.cc View 1 chunk +0 lines, -167 lines 0 comments Download
M content/renderer/media/peer_connection_handler_base.h View 1 chunk +2 lines, -2 lines 0 comments Download
D content/renderer/media/peer_connection_handler_unittest.cc View 1 chunk +0 lines, -201 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
perkj_chrome
Hej Can you help me review this cl where we remove all files related to ...
8 years, 5 months ago (2012-07-19 08:22:15 UTC) #1
perkj_chrome
On 2012/07/19 08:22:15, perkj wrote: > Hej > Can you help me review this cl ...
8 years, 5 months ago (2012-07-19 08:25:05 UTC) #2
piman
On 2012/07/19 08:25:05, perkj wrote: > On 2012/07/19 08:22:15, perkj wrote: > > Hej > ...
8 years, 5 months ago (2012-07-19 08:29:33 UTC) #3
Nirnimesh
chrome/test LGTM
8 years, 5 months ago (2012-07-20 02:12:20 UTC) #4
tommi (sloooow) - chröme
lgtm. A note on the cl description - if there's no bug that the the ...
8 years, 5 months ago (2012-07-20 09:06:28 UTC) #5
perkj_chrome
jam- can you help out with the content gypi files? Thanks
8 years, 5 months ago (2012-07-20 12:26:13 UTC) #6
jam
lgtm feel free to tbr trivial changes to gyp like this in the future
8 years, 5 months ago (2012-07-20 17:07:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/10804004/10001
8 years, 4 months ago (2012-07-26 12:28:54 UTC) #8
commit-bot: I haz the power
Presubmit check for 10804004-10001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-07-26 12:29:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/perkj@chromium.org/10804004/18001
8 years, 4 months ago (2012-07-26 12:42:23 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 14:02:05 UTC) #11
Change committed as 148548

Powered by Google App Engine
This is Rietveld 408576698