Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10804003: Android: fix test runners for non-rooted devices. (Closed)

Created:
8 years, 5 months ago by bulach
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

Android: fix test runners for non-rooted devices. Move the generated file for GetAllTests() to a public directory in the device. Adds the necessary permission to the manifest for the test. BUG= TEST=run android tests in a non-rooted device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147430

Patch Set 1 : Uses external storage #

Total comments: 4

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M build/android/pylib/test_package_apk.py View 1 2 chunks +5 lines, -3 lines 0 comments Download
M testing/android/AndroidManifest.xml View 1 chunk +1 line, -0 lines 0 comments Download
M testing/android/java/src/org/chromium/native_test/ChromeNativeTestActivity.java View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
Following comments from: http://codereview.chromium.org/10777017/
8 years, 5 months ago (2012-07-18 11:00:53 UTC) #1
nilesh
On 2012/07/18 11:00:53, bulach wrote: > Following comments from: > http://codereview.chromium.org/10777017/ LGTM
8 years, 5 months ago (2012-07-18 13:47:59 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-18 14:00:39 UTC) #3
bulach
+jrg, need a full committer review.
8 years, 5 months ago (2012-07-18 14:07:29 UTC) #4
John Grabowski
LGTM with comments added http://codereview.chromium.org/10804003/diff/2001/build/android/pylib/test_package_apk.py File build/android/pylib/test_package_apk.py (right): http://codereview.chromium.org/10804003/diff/2001/build/android/pylib/test_package_apk.py#newcode70 build/android/pylib/test_package_apk.py:70: self.adb.Adb().Pull('/sdcard/native_tests/stdout.txt', stdout_file.name) Prefer string const ...
8 years, 5 months ago (2012-07-18 20:40:49 UTC) #5
bulach
thanks! comments addressed, CQ'ing. http://codereview.chromium.org/10804003/diff/2001/build/android/pylib/test_package_apk.py File build/android/pylib/test_package_apk.py (right): http://codereview.chromium.org/10804003/diff/2001/build/android/pylib/test_package_apk.py#newcode70 build/android/pylib/test_package_apk.py:70: self.adb.Adb().Pull('/sdcard/native_tests/stdout.txt', stdout_file.name) On 2012/07/18 20:40:49, ...
8 years, 5 months ago (2012-07-19 08:14:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10804003/8001
8 years, 5 months ago (2012-07-19 09:14:00 UTC) #7
commit-bot: I haz the power
Try job failure for 10804003-8001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-19 10:12:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10804003/8001
8 years, 5 months ago (2012-07-19 10:27:27 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 12:24:45 UTC) #10
Change committed as 147430

Powered by Google App Engine
This is Rietveld 408576698