Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 10803061: [Sync] Expose change location in GenericChangeProcessor errors (Closed)

Created:
8 years, 5 months ago by Nicolas Zea
Modified:
8 years, 5 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), SteveT
Visibility:
Public.

Description

[Sync] Expose change location in GenericChangeProcessor errors BUG=135108 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M chrome/browser/sync/glue/generic_change_processor.cc View 8 chunks +15 lines, -8 lines 0 comments Download
M sync/api/sync_change.h View 1 chunk +1 line, -0 lines 0 comments Download
M sync/api/sync_change.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
PTAL. This was meant as a follow up to the previous patch, but it fell ...
8 years, 5 months ago (2012-07-20 22:58:23 UTC) #1
rlarocque
lgtm
8 years, 5 months ago (2012-07-20 23:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10803061/1
8 years, 5 months ago (2012-07-20 23:51:54 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-21 01:17:09 UTC) #4
Change committed as 147754

Powered by Google App Engine
This is Rietveld 408576698