Issue 10803055: Android Allows nested namespace in @JNINamespace annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10803055: Android Allows nested namespace in @JNINamespace annotation. (Closed)

Created:
8 years, 5 months ago by bulach

Modified:
8 years, 5 months ago

Reviewers:
Satish, benm (inactive)

CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Android Allows nested namespace in @JNINamespace annotation. There are a few cases such as PathUtils that requires "base::android". BUG= TEST=jni_generator_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147854

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -18 lines)			Patch
M	base/android/jni_generator/SampleForTests.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	base/android/jni_generator/golden_sample_for_tests_jni.h	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	base/android/jni_generator/jni_generator.py	View	4 chunks	+8 lines, -11 lines	0 comments	Download
M	base/android/jni_generator/sample_for_tests.cc	View	3 chunks	+7 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10803055/1

8 years, 5 months ago (2012-07-23 14:24:30 UTC) #4

Change committed as 147854