Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Issue 10803053: Adds SDCH config files for iOS. (Closed)

Created:
8 years, 5 months ago by rohitrao (ping after 24h)
Modified:
8 years, 5 months ago
Reviewers:
stuartmorgan, wtc
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Adds SDCH config files for iOS. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148341

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M sdch/README.chromium View 1 chunk +8 lines, -0 lines 0 comments Download
A + sdch/ios/config.h View 2 chunks +1 line, -5 lines 0 comments Download
M sdch/sdch.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rohitrao (ping after 24h)
wtc for review, stuart for fyi. This is a straight upstreaming of the sdch changes ...
8 years, 5 months ago (2012-07-20 10:06:56 UTC) #1
wtc
LGTM. https://chromiumcodereview.appspot.com/10803053/diff/1/sdch/ios/config.h File sdch/ios/config.h (right): https://chromiumcodereview.appspot.com/10803053/diff/1/sdch/ios/config.h#newcode35 sdch/ios/config.h:35: #define HAVE_POSIX_MEMALIGN 1 Did you add this file ...
8 years, 5 months ago (2012-07-20 16:56:00 UTC) #2
stuartmorgan
On 2012/07/20 16:56:00, wtc wrote: > Did you add this file using "svn copy"? This ...
8 years, 5 months ago (2012-07-21 04:16:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10803053/5001
8 years, 5 months ago (2012-07-24 14:12:54 UTC) #4
commit-bot: I haz the power
Presubmit check for 10803053-5001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-24 14:12:56 UTC) #5
rohitrao (ping after 24h)
8 years, 5 months ago (2012-07-25 17:01:44 UTC) #6
I committed this manually using git cl dcommit.  Thanks for the review!

Interestingly, this committed config.h as a new file, not as a
copy+modification.  No idea why, but it looks like we got the correct behavior
in the end.

Powered by Google App Engine
This is Rietveld 408576698