Add the ability to get info of a Http connection, e.g. host and port.

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class _HttpHeaders implements HttpHeaders {
   _HttpHeaders() : _headers = new Map<String, List<String>>();
 
   List<String> operator[](String name) {
     name = name.toLowerCase();
     return _headers[name];
@@ skipping 689 matching lines @@
     }
   }
 
   void _updateContentLength(int bytes) {
     if (_bodyBytesWritten + bytes > _contentLength) {
       throw new HttpException("Writing more than specified content length");
     }
     _bodyBytesWritten += bytes;
   }
 
+  HttpConnectionInfo get connectionInfo() {

[Bill Hesse, 2012/07/19 15:05:10]

Why not => notation here?

+    return _httpConnection.connectionInfo();
+  }
+
   int _state;
   bool _headResponse;
 
   _HttpConnectionBase _httpConnection;
   _HttpHeaders _headers;
   List<Cookie> _cookies;
   String _protocolVersion = "1.1";
 
   // Length of the content body. If this is set to -1 (default value)
   // when starting to send data chunked transfer encoding will be
@@ skipping 514 matching lines @@
     _socket.onData = null;
     _socket.onClosed = null;
     _socket.onError = null;
     _socket.outputStream.onNoPendingWrites = null;
     Socket socket = _socket;
     _socket = null;
     if (onDetach != null) onDetach();
     return new _DetachedSocket(socket, _httpParser.unparsedData);
   }
 
+  HttpConnectionInfo get connectionInfo() {
+    if (_socket == null || _closing || _error) return null;
+    try {
+      HttpConnectionInfo info = new _HttpConnectionInfo();
+      info.remoteHost = _socket.remoteHost;

[Bill Hesse, 2012/07/19 15:05:10]

Why not have a constructor
_HttpConnectionInfo(this.remoteHost, this.remotePort, this.localPort);
?  It makes me think something weird is going on when I see this weird
assignment to fields after construction.

[Anders Johnsen, 2012/07/19 15:12:44]

_HttpConnectionInfo is a simple data container. Using a constructor will be
quite annoying when expanding with more properties and we would loose the nice
property of having explicit named assignments.

+      info.remotePort = _socket.remotePort;
+      info.localPort = _socket.port;
+      return info;
+    } catch (var e) { }
+    return null;
+  }
+
   abstract void _onConnectionClosed(e);
   abstract void _responseDone();
 
   void set _onNoPendingWrites(void callback()) {
     if (!_error) {
       _socket.outputStream.onNoPendingWrites = callback;
     }
   }
 
   int hashCode() => _hashCode;
@@ skipping 839 matching lines @@
   }
 
   Function _onOpen;
   Map<String, Queue<_SocketConnection>> _openSockets;
   Set<_SocketConnection> _activeSockets;
   Timer _evictionTimer;
   bool _shutdown;  // Has this HTTP client been shutdown?
 }
 
 
+class _HttpConnectionInfo implements HttpConnectionInfo {
+  String remoteHost;
+  String remotePort;
+  String localPort;
+}
+
+
 class _DetachedSocket implements DetachedSocket {
   _DetachedSocket(this._socket, this._unparsedData);
   Socket get socket() => _socket;
   List<int> get unparsedData() => _unparsedData;
   Socket _socket;
   List<int> _unparsedData;
 }
 
 
 class _RedirectInfo implements RedirectInfo {
   const _RedirectInfo(int this.statusCode,
                       String this.method,
                       Uri this.location);
   final int statusCode;
   final String method;
   final Uri location;
 }