Add read/write tests, index creation/deletion test.

Add read/write tests, index creation/deletion test.

This is based on https://chromiumcodereview.appspot.com/10790041/, not yet submitted.

BUG=137764
TEST=self

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148635

[jsbell, 2012-07-19 00:28:57]

Eyes glazing over, will take a deeper look tomorrow, but I noticed this.

https://chromiumcodereview.appspot.com/10803029/diff/2001/chrome/test/data/in...
File chrome/test/data/indexeddb/perf_shared.js (right):

https://chromiumcodereview.appspot.com/10803029/diff/2001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:91: setVersionRequest.onfailure =
errorHandler;
Should be onerror not onfailure.

[ericu, 2012-07-24 21:58:07]

https://chromiumcodereview.appspot.com/10803029/diff/2001/chrome/test/data/in...
File chrome/test/data/indexeddb/perf_shared.js (right):

https://chromiumcodereview.appspot.com/10803029/diff/2001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:91: setVersionRequest.onfailure =
errorHandler;
On 2012/07/19 00:28:57, jsbell wrote:
> Should be onerror not onfailure.

Whoops!  Of course it should.  Fixed in 2 places.

[jsbell, 2012-07-26 18:52:41]

Overall lgtm, some issues noted.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
File chrome/test/data/indexeddb/perf_shared.js (right):

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_shared.js:81: var db = openRequest.result;
Ignore my comment in the previous review.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_shared.js:117: // TODO: This won't work in
Firefox yet; see above in createDatabase.
I wrote an upgradeneeded shim for the current version of Chrome you could use
until we land the real version (coming real soon!)

https://bugs.webkit.org/attachment.cgi?id=154148&action=review

Search for "feature-detect"

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_shared.js:182: Array.prototype.slice.call(args,
0, args.length - 1).join("_");
Cute. :) Maybe a comment that last argument is assumed to be a callback function
and so not included.

(Alternately, could do a map() that does a typeof check and uses the name for
function args.)

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_shared.js:200: var os =
transaction.objectStore(objectStoreNames[i]);
This will throw if not found, never return null. So the assertion is fine, but
it validates the IDB implementation more than the test logic.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_shared.js:216: var queryObject = os;
FYI, in the IDB spec itself this (a store or index) would be called the "source"
of a request.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
File chrome/test/data/indexeddb/perf_test.js (right):

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_test.js:48: function () { return "test value";
});
Isn't this being specified for the getKey argument?

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_test.js:115: }
Missing semicolon.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_test.js:130: }
Missing semicolon.

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_test.js:135: function onIndexDeleted(db) {
Not used?

http://codereview.chromium.org/10803029/diff/9001/chrome/test/data/indexeddb/...
chrome/test/data/indexeddb/perf_test.js:136: cleanUpFunc(db);
The function returned by getCleanUpFunc() doesn't take args.

[ericu, 2012-07-26 21:03:12]

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
File chrome/test/data/indexeddb/perf_shared.js (right):

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:117: // TODO: This won't work in
Firefox yet; see above in createDatabase.
On 2012/07/26 18:52:41, jsbell wrote:
> I wrote an upgradeneeded shim for the current version of Chrome you could use
> until we land the real version (coming real soon!)
> 
> https://bugs.webkit.org/attachment.cgi?id=154148&action=review
> 
> Search for "feature-detect"

I'll consider adding that in a later CL, especially if this hack doesn't work
when I start testing in Firefox.  Thanks for the pointer.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:182: Array.prototype.slice.call(args,
0, args.length - 1).join("_");
On 2012/07/26 18:52:41, jsbell wrote:
> Cute. :) Maybe a comment that last argument is assumed to be a callback
function
> and so not included.
> 
> (Alternately, could do a map() that does a typeof check and uses the name for
> function args.)

Done.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:200: var os =
transaction.objectStore(objectStoreNames[i]);
On 2012/07/26 18:52:41, jsbell wrote:
> This will throw if not found, never return null. So the assertion is fine, but
> it validates the IDB implementation more than the test logic.

Removed.  It'll fail quickly enough anyway.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_shared.js:216: var queryObject = os;
On 2012/07/26 18:52:41, jsbell wrote:
> FYI, in the IDB spec itself this (a store or index) would be called the
"source"
> of a request.

Sounds good; changed to "source".

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
File chrome/test/data/indexeddb/perf_test.js (right):

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_test.js:48: function () { return "test value";
});
On 2012/07/26 18:52:41, jsbell wrote:
> Isn't this being specified for the getKey argument?

Yup; fixed.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_test.js:115: }
On 2012/07/26 18:52:41, jsbell wrote:
> Missing semicolon.

Done.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_test.js:130: }
On 2012/07/26 18:52:41, jsbell wrote:
> Missing semicolon.

Done.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_test.js:135: function onIndexDeleted(db) {
On 2012/07/26 18:52:41, jsbell wrote:
> Not used?

Removed.

https://chromiumcodereview.appspot.com/10803029/diff/9001/chrome/test/data/in...
chrome/test/data/indexeddb/perf_test.js:136: cleanUpFunc(db);
On 2012/07/26 18:52:41, jsbell wrote:
> The function returned by getCleanUpFunc() doesn't take args.

Done.