Issue 10803008: Expose counters in javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10803008: Expose counters in javascript. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Expose counters in javascript. R=rossberg BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12124

Patch Set 1 #

Total comments: 3

Patch Set 2 : changed name and stringifying #

Patch Set 3 : . #

Patch Set 4 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -7 lines)			Patch
M	src/SConscript	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/bootstrapper.cc	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	src/d8.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	src/extensions/statistics-extension.h	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
A	src/extensions/statistics-extension.cc	View	1 2 3	1 chunk	+100 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rossberg

8 years, 5 months ago (2012-07-18 12:23:39 UTC) #2

LGTM, with one remaining comment.

https://chromiumcodereview.appspot.com/10803008/diff/1/src/extensions/counter...
File src/extensions/counters-extension.cc (right):

https://chromiumcodereview.appspot.com/10803008/diff/1/src/extensions/counter...
src/extensions/counters-extension.cc:28: #include "counters-extension.h"
Can we perhaps call that "stats"?

https://chromiumcodereview.appspot.com/10803008/diff/1/src/extensions/counter...
src/extensions/counters-extension.cc:59: #define STR(s) #s
As discussed offline, you could get rid of this one.

https://chromiumcodereview.appspot.com/10803008/diff/1/src/extensions/counter...
src/extensions/counters-extension.cc:64:
v8::Number::New(static_cast<double>(*counter->GetInternalPointer())));
Is the cast necessary? (here and below)

Expand Messages | Collapse Messages