Issue 10802091: Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10802091: Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash (Closed)

Created:
8 years, 5 months ago by f(malita)

Modified:
8 years, 5 months ago

Reviewers:
f(malita)

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1180/

Visibility:
Public.

More Reviews

Description

Merge 122755 - SVGAnimationElement::currentValuesForValuesAnimation crash https://bugs.webkit.org/show_bug.cgi?id=91326 Reviewed by Simon Fraser. SVGSMILElement::progress() assumes that seekToIntervalCorrespondingToTime() always lands inside a defined interval, but one can force arbitrary time offsets using setCurrentTime(). This patch adds logic for handling non-interval time offsets gracefully. Source/WebCore: Test: svg/animations/smil-setcurrenttime-crash.svg * svg/animation/SVGSMILElement.cpp: (WebCore::SVGSMILElement::progress): LayoutTests: * svg/animations/smil-setcurrenttime-crash-expected.txt: Added. * svg/animations/smil-setcurrenttime-crash.svg: Added. TBR=fmalita@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123508

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, --1 lines)			Patch
A +	LayoutTests/svg/animations/smil-setcurrenttime-crash.svg	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	LayoutTests/svg/animations/smil-setcurrenttime-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/WebCore/svg/animation/SVGSMILElement.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages