Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: ui/views/widget/native_widget_win.cc

Issue 10802085: Correct behaviour of touch wrt mouse capture. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Factored out common code. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/widget/native_widget_win.cc
diff --git a/ui/views/widget/native_widget_win.cc b/ui/views/widget/native_widget_win.cc
index b04bc7f46be5d028ee2bca51afb822a04e5186be..df4d1f0fc9c3bc6b681b3ded9f0254da5af1aa94 100644
--- a/ui/views/widget/native_widget_win.cc
+++ b/ui/views/widget/native_widget_win.cc
@@ -58,9 +58,6 @@
#pragma comment(lib, "dwmapi.lib")
-// From msdn:
-#define MOUSEEVENTF_FROMTOUCH 0xFF515700
-
using ui::ViewProp;
namespace views {
@@ -1631,12 +1628,7 @@ LRESULT NativeWidgetWin::OnMouseRange(UINT message,
MSG msg = { hwnd(), message, w_param, l_param, 0,
{ GET_X_LPARAM(l_param), GET_Y_LPARAM(l_param) } };
MouseEvent event(msg);
- // Only button up/down have MOUSEEVENTF_FROMTOUCH set.
- if (!touch_ids_.empty() ||
- ((message == WM_LBUTTONDOWN || message == WM_LBUTTONUP ||
- message == WM_RBUTTONDOWN || message == WM_RBUTTONUP) &&
- (GetMessageExtraInfo() & MOUSEEVENTF_FROMTOUCH) ==
- MOUSEEVENTF_FROMTOUCH)) {
+ if (!touch_ids_.empty() || base::win::IsMouseEventFromTouch(message)) {
flackr 2012/07/24 19:53:04 nit: no braces for single line if statement.
girard 2012/07/24 23:54:55 Done.
event.set_flags(event.flags() | ui::EF_FROM_TOUCH);
}

Powered by Google App Engine
This is Rietveld 408576698