Issue 10802067: net: don't crash when failing dynamic pins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10802067: net: don't crash when failing dynamic pins. (Closed)

Created:
8 years, 5 months ago by agl

Modified:
8 years, 5 months ago

Reviewers:
palmer, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: don't crash when failing dynamic pins. ssl_client_socket_nss.cc calls ReportUMAOnPinFailure when pinning fails. However, that function currently assumes that the pin failure came from a built-in pin. When that's not the case, it hits a NULL pointer. BUG=138521 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147926