Fix corner case when transforming dictionary to fast elements.

Fix corner case when transforming dictionary to fast elements.


R=verwaest@chromium.org
BUG=v8:2249
TEST=regress-2249.js

Committed: https://code.google.com/p/v8/source/detail?r=12167

[Yang, 2012-07-20 13:40:01]

PTAL.

http://codereview.chromium.org/10802051/diff/2001/src/compiler.cc
File src/compiler.cc (right):

http://codereview.chromium.org/10802051/diff/2001/src/compiler.cc#newcode823
src/compiler.cc:823: ASSERT(closure->IsMarkedForParallelRecompilation());
Sneaking in a small fix in here :)

[Toon Verwaest, 2012-07-20 13:47:48]

LGTM with nits.

http://codereview.chromium.org/10802051/diff/2001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12463
src/objects.cc:12463: }
What about moving all of this code (starting from // Calculate fields ...) below
the == 0?

http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12466
src/objects.cc:12466: ASSERT_EQ(0, number_of_allocated_fields);
Here we can just use number_of_fields.

[Yang, 2012-07-20 14:28:48]

On 2012/07/20 13:47:48, Toon Verwaest wrote:
> LGTM with nits.
> 
> http://codereview.chromium.org/10802051/diff/2001/src/objects.cc
> File src/objects.cc (right):
> 
> http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12463
> src/objects.cc:12463: }
> What about moving all of this code (starting from // Calculate fields ...)
below
> the == 0?
> 
> http://codereview.chromium.org/10802051/diff/2001/src/objects.cc#newcode12466
> src/objects.cc:12466: ASSERT_EQ(0, number_of_allocated_fields);
> Here we can just use number_of_fields.

PTAL.

[Toon Verwaest, 2012-07-20 14:34:18]

lgtm