Issue 10802048: Removed recording of Target Slot in transition arrays since they only contain maps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10802048: Removed recording of Target Slot in transition arrays since they only contain maps. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed recording of Target Slot in transition arrays since they only contain maps. Committed: https://code.google.com/p/v8/source/detail?r=12215

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -14 lines)			Patch
M	src/objects.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download
M	src/transitions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/transitions-inl.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

8 years, 5 months ago (2012-07-27 09:59:29 UTC) #2

LGTM (with a nit).

https://chromiumcodereview.appspot.com/10802048/diff/1/src/objects.cc
File src/objects.cc (right):

https://chromiumcodereview.appspot.com/10802048/diff/1/src/objects.cc#newcode...
src/objects.cc:7159: t->SetTarget(transition_index, t->GetTarget(i));
Can we have a one line comment above this line saying that we don't need to
record slots because we don't compact maps.

Expand Messages | Collapse Messages