Issue 10802039: Don't record elements transition slots since it will contain a map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10802039: Don't record elements transition slots since it will contain a map. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't record elements transition slots since it will contain a map. Additionally removed unused code. Committed: https://code.google.com/p/v8/source/detail?r=12150

Patch Set 2 : Addressed nit. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -29 lines)			Patch
M	src/mark-compact.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View	1	2 chunks	+0 lines, -17 lines	0 comments	Download
M	src/transitions.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/transitions.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/transitions-inl.h	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one nit). I like this change. https://chromiumcodereview.appspot.com/10802039/diff/1/src/transitions.cc File src/transitions.cc (right): https://chromiumcodereview.appspot.com/10802039/diff/1/src/transitions.cc#newcode73 src/transitions.cc:73: maybe_array ...

8 years, 5 months ago (2012-07-19 21:09:02 UTC) #2

Addressed nit.

Expand Messages | Collapse Messages

Issue 10802039: Don't record elements transition slots since it will contain a map. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed nit. #

Messages