Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10802034: Moved lastadded from DescriptorArray to Map. Renamed kLastAdded to kEnumCache. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest
Modified:
8 years, 5 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Moved lastadded from DescriptorArray to Map. Renamed kLastAdded to kEnumCache. Committed: https://code.google.com/p/v8/source/detail?r=12146

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -118 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M src/heap.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 6 chunks +27 lines, -32 lines 0 comments Download
M src/objects.cc View 1 13 chunks +35 lines, -37 lines 0 comments Download
M src/objects-inl.h View 4 chunks +10 lines, -18 lines 0 comments Download
M src/transitions-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
PTAL.
8 years, 5 months ago (2012-07-19 14:12:41 UTC) #1
Jakob Kummerow
A few nits, and a question in objects.cc. https://chromiumcodereview.appspot.com/10802034/diff/1/src/heap.cc File src/heap.cc (right): https://chromiumcodereview.appspot.com/10802034/diff/1/src/heap.cc#newcode2056 src/heap.cc:2056: Object* ...
8 years, 5 months ago (2012-07-19 14:35:00 UTC) #2
Jakob Kummerow
LGTM after offline discussion. (But do fix the remaining nits, please.)
8 years, 5 months ago (2012-07-19 14:41:15 UTC) #3
Toon Verwaest
8 years, 5 months ago (2012-07-19 14:42:54 UTC) #4
Addressed comments.

Powered by Google App Engine
This is Rietveld 408576698