Issue 108013002: Revert of Add build_config_functions.h to avoid #ifdef

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108013002: Revert of Add build_config_functions.h to avoid #ifdef (Closed)

Created:
7 years ago by jln (very slow on Chromium)

Modified:
7 years ago

Reviewers:
Robert Sesek, darin (slow to review), willchan no longer on Chromium

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, agl, jln+watch_chromium.org, Jeffrey Yasskin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -118 lines)			Patch
M	build/build_config.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
D	build/build_config_functions.h	View	1 chunk	+0 lines, -110 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/bpf_tests.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	sandbox/linux/seccomp-bpf/sandbox_bpf_unittest.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	sandbox/linux/tests/unit_tests.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sandbox/linux/tests/unit_tests.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jln (very slow on Chromium)

Created Revert of Add build_config_functions.h to avoid #ifdef

7 years ago (2013-12-06 08:52:23 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jln@chromium.org/108013002/1

7 years ago (2013-12-06 08:53:33 UTC) #2

Message was sent while issue was closed.

Change committed as 239153