Issue 10801009: Android test runner: Sync missing JS files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10801009: Android test runner: Sync missing JS files (Closed)

Created:
8 years, 5 months ago by haitao.feng

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow (corp), ulan, Jakob Kummerow

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Android test runner: Sync missing JS files Committed: https://code.google.com/p/v8/source/detail?r=12125

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tools/android-sync.sh	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

haitao.feng

Those files are required by mjsunit/tools. However the mjsunit/tools/tickprocessor could not pass as it wants ...

8 years, 5 months ago (2012-07-18 11:50:28 UTC) #1

Jakob Kummerow

8 years, 5 months ago (2012-07-18 12:38:38 UTC) #2

LGTM, I'll land this.

I know that we have some tests that create temporary files in /tmp/. Don't worry
about those; I will change that in the not-too-distant future as part of a major
overhaul of our test driver. ETA: some time this quarter. In the meantime, if
the failures bother you, feel free to mark the affected tests as either SKIP or
FAIL in mjsunit.status in a yet-to-be-created [ $arch == android_ia32 || $arch
== android_arm ] section. (Or just ignore them.)

As for d8-os: let's just skip that (in mjsunit.status) on Android, as it simply
doesn't make sense to run it there.

Expand Messages | Collapse Messages