Issue 10801006: Allow secondary tiles to be unpinned.

Issue 10801006: Allow secondary tiles to be unpinned. (Closed)

Created:
8 years, 5 months ago by benwells

Modified:
8 years, 5 months ago

Reviewers:
ananta, sky

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, chrome-win8-eng_google.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Allow secondary tiles to be unpinned. This change updates the pin menu item to say 'Unpin from Start Screen' when the item is pinned, and if the menu is clicked the tile will be unpinned from the start screen. This change is accompanied by a corresponding change to metro_driver.dll BUG=129598 TEST=Check secondary tiles can be pinned and unpinned from the start screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147347

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : Remove NULL check #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -30 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_command_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1 2	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/browser_win.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
A	chrome/browser/ui/metro_pin_tab_helper.h	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/metro_pin_tab_helper.cc	View	1	1 chunk	+74 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.h	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	1	3 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

benwells

Next steps for unpinning: (1) add a pin icon to the omnibar (2) fix the ...

8 years, 5 months ago (2012-07-18 11:04:38 UTC) #1

sky

LGTM http://codereview.chromium.org/10801006/diff/6001/chrome/browser/ui/browser_commands.cc File chrome/browser/ui/browser_commands.cc (right): http://codereview.chromium.org/10801006/diff/6001/chrome/browser/ui/browser_commands.cc#newcode605 chrome/browser/ui/browser_commands.cc:605: if (current_tab) You shouldn't need a NULL check ...

8 years, 5 months ago (2012-07-18 15:21:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10801006/6001

8 years, 5 months ago (2012-07-18 22:34:37 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/10801006/8005

8 years, 5 months ago (2012-07-18 22:45:36 UTC) #6

Change committed as 147347

Expand Messages | Collapse Messages