Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1200)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/ddbg.dart

Issue 10801002: Add multibyte string support to debugger (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/platform/json.cc ('K') | « runtime/platform/json.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/ddbg.dart
===================================================================
--- tools/ddbg.dart (revision 9748)
+++ tools/ddbg.dart (working copy)
@@ -7,7 +7,9 @@
#import("dart:io");
#import("dart:json");
+#import("dart:utf");
+
Map<int, Completer> outstandingCommands;
Socket vmSock;
@@ -428,7 +430,7 @@
};
var vmInStream = new SocketInputStream(vmSock);
vmInStream.onData = () {
- var s = new String.fromCharCodes(vmInStream.read());
+ String s = decodeUtf8(vmInStream.read());
processVmData(s);
};
vmInStream.onError = (err) {
« runtime/platform/json.cc ('K') | « runtime/platform/json.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698