Add multibyte string support to debugger

runtime/bin/dbg_connection.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/dbg_connection.h"
 #include "bin/dartutils.h"
 #include "bin/socket.h"
 #include "bin/thread.h"
 #include "bin/utils.h"
 
@@ skipping 306 matching lines @@
 
 
 void DebuggerConnectionHandler::HandleStepOverCmd(const char* json_msg) {
   Dart_Handle res = Dart_SetStepOver();
   ASSERT_NOT_ERROR(res);
   HandleResumeCmd(json_msg);
 }
 
 
 static void FormatEncodedString(dart::TextBuffer* buf, Dart_Handle str) {
-  ASSERT(Dart_IsString8(str));
   intptr_t str_len = 0;
   Dart_Handle res = Dart_StringLength(str, &str_len);
   ASSERT_NOT_ERROR(res);
-  uint8_t* codepoints = reinterpret_cast<uint8_t*>(malloc(str_len));
+  uint32_t* codepoints =
+      reinterpret_cast<uint32_t*>(malloc(str_len * sizeof(uint32_t)));
   ASSERT(codepoints != NULL);
   intptr_t actual_len = str_len;
-  res = Dart_StringGet8(str, codepoints, &actual_len);
+  res = Dart_StringGet32(str, codepoints, &actual_len);
+  ASSERT_NOT_ERROR(res);
   ASSERT(str_len == actual_len);
-  buf->Printf("\"");
-  buf->PrintJsonString8(codepoints, str_len);
-  buf->Printf("\"");
+  buf->AddChar('\"');
+  for (int i = 0; i < str_len; i++) {
+    buf->AddEscapedChar(codepoints[i]);
+  }
+  buf->AddChar('\"');
   free(codepoints);
 }
 
 
 static void FormatErrorMsg(dart::TextBuffer* buf, Dart_Handle err) {
   // TODO(hausner): Turn message into Dart string and
   // properly encode the message.
   ASSERT(Dart_IsError(err));
   const char* msg = Dart_GetError(err);
   buf->Printf("\"%s\"", msg);
@@ skipping 675 matching lines @@
   DebuggerConnectionImpl::StartHandler(port_number);
   Dart_SetBreakpointHandler(BreakpointHandler);
   Dart_SetBreakpointResolvedHandler(BptResolvedHandler);
   Dart_SetExceptionThrownHandler(ExceptionThrownHandler);
 }
 
 
 DebuggerConnectionHandler::~DebuggerConnectionHandler() {
   CloseDbgConnection();
 }