Issue 10800096: views: Remove the implementation of about chrome dialog.

Issue 10800096: views: Remove the implementation of about chrome dialog. (Closed)

Created:
8 years, 5 months ago by tfarina

Modified:
8 years, 5 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, jennb, jianli, Dmitry Titov, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

views: Remove the implementation of about chrome dialog. Now that http://crbug.com/115123 is fixed, we can remove the views implementation, and along the way we can remove the ShowAboutChromeDialog function from BrowseWindow and the platform-specific overridden functions. BUG=138724 R=pkasting@chromium.org TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148474

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -979 lines)			Patch
M	chrome/browser/ui/browser_window.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_cocoa.mm	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/browser_window_gtk.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel_browser_window.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
D	chrome/browser/ui/views/about_chrome_view.h	View	1 chunk	+0 lines, -149 lines	0 comments	Download
D	chrome/browser/ui/views/about_chrome_view.cc	View	1 chunk	+0 lines, -796 lines	0 comments	Download
M	chrome/browser/ui/views/browser_dialogs.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/test/base/test_browser_window.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/base/test_browser_window.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

tfarina

On Tuesday, July 24, 2012, wrote: > I don't think you meant 15123... > > ...

8 years, 5 months ago (2012-07-25 00:49:02 UTC) #3

tfarina

To be more precisely, https://chromiumcodereview.appspot.com/10698106

8 years, 5 months ago (2012-07-25 13:44:33 UTC) #4

LGTM