Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10800083: retry r147895 (Closed)

Created:
8 years, 5 months ago by Evan Stade
Modified:
8 years, 5 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

retry r147895: switch mediaGalleries to .idl api definition BUG=none TEST=manual TBR=asargent Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148011

Patch Set 1 #

Patch Set 2 : docs #

Patch Set 3 : fix weird non-ascii byte in idl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+383 lines, -474 lines) Patch
A + chrome/browser/extensions/api/media_galleries/media_galleries_api.h View 1 chunk +7 lines, -17 lines 0 comments Download
A + chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 4 chunks +33 lines, -13 lines 0 comments Download
A + chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/extensions/api/media_gallery/media_gallery_api.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/extensions/api/media_gallery/media_gallery_api.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D chrome/browser/extensions/api/media_gallery/media_gallery_apitest.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/common/extensions/api/experimental_media_galleries.idl View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
D chrome/common/extensions/api/experimental_media_galleries.json View 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/apps/experimental.mediaGalleries.html View 1 2 13 chunks +136 lines, -57 lines 0 comments Download
M chrome/common/extensions/docs/extensions/experimental.mediaGalleries.html View 1 2 17 chunks +141 lines, -61 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/docs/samples.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/media_galleries/manifest.json View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/test/data/extensions/api_test/media_galleries/test.js View 1 chunk +3 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/media_gallery/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/media_gallery/test.js View 1 chunk +0 lines, -48 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Stade
I don't understand what the failures were before, several bots reported media_gallery_api.cc missing, but of ...
8 years, 5 months ago (2012-07-23 20:56:43 UTC) #1
vandebo (ex-Chrome)
8 years, 5 months ago (2012-07-23 20:59:13 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698