Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 10800074: Making AutoLoginPrompter::ParseAutoLoginHeader public. (Closed)

Created:
8 years, 5 months ago by qsr
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Making AutoLoginPrompter::ParseAutoLoginHeader public. iOS needs to parse the AutoLogin header but doesn't follow the same path than other platform to obtain it. Making this method public ensures that implementation is shared between platforms. R=pkasting@chromium.org TEST=None BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148128

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changing method implementation order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M chrome/browser/ui/auto_login_prompter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/auto_login_prompter.cc View 1 2 chunks +37 lines, -37 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
qsr
8 years, 5 months ago (2012-07-23 15:42:44 UTC) #1
qsr
With the right pkasting.
8 years, 5 months ago (2012-07-23 15:43:35 UTC) #2
Peter Kasting
OWNERS LGTM, but you should ensure that whatever you're ultimately doing is OK with the ...
8 years, 5 months ago (2012-07-23 18:09:31 UTC) #3
qsr
> OWNERS LGTM, but you should ensure that whatever you're ultimately doing is OK > ...
8 years, 5 months ago (2012-07-24 07:01:43 UTC) #4
qsr
+Roger for review. http://codereview.chromium.org/10800074/diff/1/chrome/browser/ui/auto_login_prompter.h File chrome/browser/ui/auto_login_prompter.h (right): http://codereview.chromium.org/10800074/diff/1/chrome/browser/ui/auto_login_prompter.h#newcode41 chrome/browser/ui/auto_login_prompter.h:41: static bool ParseAutoLoginHeader(const std::string& input, Params* ...
8 years, 5 months ago (2012-07-24 07:02:19 UTC) #5
Roger Tawa OOO till Jul 10th
lgtm
8 years, 5 months ago (2012-07-24 14:51:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/10800074/1002
8 years, 5 months ago (2012-07-24 15:31:31 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 17:00:07 UTC) #8
Change committed as 148128

Powered by Google App Engine
This is Rietveld 408576698