Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 10800072: When looking up a file in the first IDs list, and the file is outside of the tree starting at SRCDI… (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 5 months ago
Reviewers:
joi
CC:
grit-developer_googlegroups.com
Visibility:
Public.

Description

When looking up a file in the first IDs list, and the file is outside of the tree starting at SRCDIR, just use the filename as key BUG=none TEST=building content_shell from within WebKit works for Release mode Committed: https://code.google.com/p/grit-i18n/source/detail?r=58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M grit/node/misc.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jochen (gone - plz use gerrit)
8 years, 5 months ago (2012-07-23 13:12:15 UTC) #1
please review

The issue I have is that in chromium's resource_ids file, there's a key
<(SHARED_INTERMEDIATE_DIR)/devtools/devtools_resources.grd.
SHARED_INTERMEDIATE_DIR is a relative path, and when building chrome, this path
is indeed also relative to the SRCDIR defined in the resource_ids file.

When building WebKit, however, the SHARED_INTERMEDIATE_DIR is relative to
WebKit's root, and so the key resulting for replacing SHARED_INTERMEDIATE_DIR
doesn't make sense anymore.

I managed to work around by adding devtools_resources.grd as key. It turns out,
however, that just worked because my WebKit output directory for a debug build
had the correct size, so chopping of len(src_root_dir)+1 characters from the
absolute path resulted in devtools_resources.grd. When you do a Release build,
the path length is different, and so the key is not found.

Instead of relying on the path lengths, I introduced an explicit check: If the
file is outside of src_root_dir, just use the filename as key.

Powered by Google App Engine
This is Rietveld 408576698