Issue 10800062: [Web Intents, OSX] White background for picker dialog.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10800062: [Web Intents, OSX] White background for picker dialog. (Closed)

Created:
8 years, 5 months ago by groby-ooo-7-16

Modified:
8 years, 5 months ago

Reviewers:
Nico

CC:
chromium-reviews, gbillock+watch_chromium.org, smckay+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Web Intents, OSX] White background for picker dialog. R=thakis@chromium.org BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148037

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/ui/cocoa/web_intent_sheet_controller.mm	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

lgtm i assume some ux person asked for this? sheets usually aren't white https://chromiumcodereview.appspot.com/10800062/diff/1/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm File ...

8 years, 5 months ago (2012-07-21 00:43:30 UTC) #2

groby-ooo-7-16

Yes - that's basically one step towards the new dialog style. (Keeping it local in ...

8 years, 5 months ago (2012-07-24 00:46:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10800062/1

8 years, 5 months ago (2012-07-24 00:46:29 UTC) #4

Change committed as 148037

Expand Messages | Collapse Messages