Extension Docs Server Version 2: Various fixes.

Extension Docs Server Version 2: Various fixes.

Callbacks no longer appear when they shouldn't.
Types now have events.
Page_capture api now has the onChange event.
Step 1 appears in the table of contents for the permissions API.

BUG=138167
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147890

[chebert, 2012-07-20 01:36:52]

A put of bunch of little things into one.

Let me know if I should break this up into more CL's.

[not at google - send to devlin, 2012-07-20 02:04:54]

lgtm

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:73: 'events':
map(self._GenerateEvent, type_.events.values())
types have events? whoa.

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/templates/intros/permissions.html
(right):

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/templates/intros/permissions.html:16: <h3
id="types"> Step 1: Decide which permissions are optional and required </h3>
maybe we should fix the parser rather than fix the HTML... this is probably just
going to happen again. The current parser is just regex I believe but python has
HTML parsers.

do that later though, this change is fine for now.

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
File
chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json
(left):

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json:134:
"simple_type": "object"
why this change? isn't not fine down here?

[chebert, 2012-07-21 19:40:30]

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
File chrome/common/extensions/docs/server2/handlebar_dict_generator.py (right):

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/handlebar_dict_generator.py:73: 'events':
map(self._GenerateEvent, type_.events.values())
ChromeSetting is the only type where I have seen this. (types.html)

On 2012/07/20 02:04:54, kalman wrote:
> types have events? whoa.

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
File
chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json
(left):

https://chromiumcodereview.appspot.com/10800047/diff/2001/chrome/common/exten...
chrome/common/extensions/docs/server2/test_data/test_json/expected_test_file.json:134:
"simple_type": "object"
No its fine. I moved it back.

On 2012/07/20 02:04:54, kalman wrote:
> why this change? isn't not fine down here?

[commit-bot: I haz the power, 2012-07-21 19:40:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10800...

[commit-bot: I haz the power, 2012-07-21 19:40:59]

Presubmit check for 10800047-7001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
./subversion_file_system_test.py failed!
Command ./subversion_file_system_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
F..
======================================================================
FAIL: testListDir (__main__.SubversionFileSystemTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./subversion_file_system_test.py", line 32, in testListDir
    sorted(self._file_system.Read(['list/']).Get()['list/']))
AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html', 'file3.html',
'file4.html', 'file5.html', 'file6.html'] != [u'.svn/', u'dir/', u'file0.html',
u'file1.html', u'file2.html', u'file3.html', u'file4.html', u'file5.html',
u'file6.html']

----------------------------------------------------------------------
Ran 3 tests in 0.003s

FAILED (failures=1)


./local_file_system_test.py failed!
Command ./local_file_system_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
F.
======================================================================
FAIL: testListDir (__main__.LocalFileSystemTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./local_file_system_test.py", line 31, in testListDir
    sorted(self._file_system.Read(['list/']).Get()['list/']))
AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html', 'file3.html',
'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
'file6.html']

----------------------------------------------------------------------
Ran 2 tests in 0.001s

FAILED (failures=1)


./memcache_file_system_test.py failed!
Command ./memcache_file_system_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
F.
======================================================================
FAIL: testListDir (__main__.LocalFileSystemTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./memcache_file_system_test.py", line 37, in testListDir
    sorted(self._file_system.Read(['list/']).Get()['list/']))
AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html', 'file3.html',
'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
'file6.html']

----------------------------------------------------------------------
Ran 2 tests in 0.001s

FAILED (failures=1)


Presubmit checks took 3.8s to calculate.

[cduvall, 2012-07-23 00:35:04]

On 2012/07/21 19:40:59, I haz the power (commit-bot) wrote:
> Presubmit check for 10800047-7001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> If this change requires manual test instructions to QA team, add
> TEST=[instructions].
> 
> ** Presubmit ERRORS **
> ./subversion_file_system_test.py failed!
> Command ./subversion_file_system_test.py returned non-zero exit status 1 in
> /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> F..
> ======================================================================
> FAIL: testListDir (__main__.SubversionFileSystemTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "./subversion_file_system_test.py", line 32, in testListDir
>     sorted(self._file_system.Read(['list/']).Get()['list/']))
> AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
'file3.html',
> 'file4.html', 'file5.html', 'file6.html'] != [u'.svn/', u'dir/',
u'file0.html',
> u'file1.html', u'file2.html', u'file3.html', u'file4.html', u'file5.html',
> u'file6.html']
> 
> ----------------------------------------------------------------------
> Ran 3 tests in 0.003s
> 
> FAILED (failures=1)
> 
> 
> ./local_file_system_test.py failed!
> Command ./local_file_system_test.py returned non-zero exit status 1 in
> /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> F.
> ======================================================================
> FAIL: testListDir (__main__.LocalFileSystemTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "./local_file_system_test.py", line 31, in testListDir
>     sorted(self._file_system.Read(['list/']).Get()['list/']))
> AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
'file3.html',
> 'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
> 'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
> 'file6.html']
> 
> ----------------------------------------------------------------------
> Ran 2 tests in 0.001s
> 
> FAILED (failures=1)
> 
> 
> ./memcache_file_system_test.py failed!
> Command ./memcache_file_system_test.py returned non-zero exit status 1 in
> /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> F.
> ======================================================================
> FAIL: testListDir (__main__.LocalFileSystemTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "./memcache_file_system_test.py", line 37, in testListDir
>     sorted(self._file_system.Read(['list/']).Get()['list/']))
> AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
'file3.html',
> 'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
> 'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
> 'file6.html']
> 
> ----------------------------------------------------------------------
> Ran 2 tests in 0.001s
> 
> FAILED (failures=1)
> 
> 
> Presubmit checks took 3.8s to calculate.

It failed because of the .svn directory. I think we should just make the file
systems ignore all files that start with '.'

[not at google - send to devlin, 2012-07-23 13:28:42]

On 2012/07/23 00:35:04, cduvall wrote:
> On 2012/07/21 19:40:59, I haz the power (commit-bot) wrote:
> > Presubmit check for 10800047-7001 failed and returned exit status 1.
> > 
> > Running presubmit commit checks ...
> > 
> > ** Presubmit Messages **
> > If this change requires manual test instructions to QA team, add
> > TEST=[instructions].
> > 
> > ** Presubmit ERRORS **
> > ./subversion_file_system_test.py failed!
> > Command ./subversion_file_system_test.py returned non-zero exit status 1 in
> > /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> > F..
> > ======================================================================
> > FAIL: testListDir (__main__.SubversionFileSystemTest)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "./subversion_file_system_test.py", line 32, in testListDir
> >     sorted(self._file_system.Read(['list/']).Get()['list/']))
> > AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
> 'file3.html',
> > 'file4.html', 'file5.html', 'file6.html'] != [u'.svn/', u'dir/',
> u'file0.html',
> > u'file1.html', u'file2.html', u'file3.html', u'file4.html', u'file5.html',
> > u'file6.html']
> > 
> > ----------------------------------------------------------------------
> > Ran 3 tests in 0.003s
> > 
> > FAILED (failures=1)
> > 
> > 
> > ./local_file_system_test.py failed!
> > Command ./local_file_system_test.py returned non-zero exit status 1 in
> > /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> > F.
> > ======================================================================
> > FAIL: testListDir (__main__.LocalFileSystemTest)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "./local_file_system_test.py", line 31, in testListDir
> >     sorted(self._file_system.Read(['list/']).Get()['list/']))
> > AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
> 'file3.html',
> > 'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
> > 'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
> > 'file6.html']
> > 
> > ----------------------------------------------------------------------
> > Ran 2 tests in 0.001s
> > 
> > FAILED (failures=1)
> > 
> > 
> > ./memcache_file_system_test.py failed!
> > Command ./memcache_file_system_test.py returned non-zero exit status 1 in
> > /b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
> > F.
> > ======================================================================
> > FAIL: testListDir (__main__.LocalFileSystemTest)
> > ----------------------------------------------------------------------
> > Traceback (most recent call last):
> >   File "./memcache_file_system_test.py", line 37, in testListDir
> >     sorted(self._file_system.Read(['list/']).Get()['list/']))
> > AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html',
> 'file3.html',
> > 'file4.html', 'file5.html', 'file6.html'] != ['.svn/', 'dir/', 'file0.html',
> > 'file1.html', 'file2.html', 'file3.html', 'file4.html', 'file5.html',
> > 'file6.html']
> > 
> > ----------------------------------------------------------------------
> > Ran 2 tests in 0.001s
> > 
> > FAILED (failures=1)
> > 
> > 
> > Presubmit checks took 3.8s to calculate.
> 
> It failed because of the .svn directory. I think we should just make the file
> systems ignore all files that start with '.'

hah.. that's kind of funny. ignoring things that start with . sgtm.

[commit-bot: I haz the power, 2012-07-23 17:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10800...

[commit-bot: I haz the power, 2012-07-23 17:24:54]

Presubmit check for 10800047-6002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
./subversion_file_system_test.py failed!
Command ./subversion_file_system_test.py returned non-zero exit status 1 in
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2
F..
======================================================================
FAIL: testListDir (__main__.SubversionFileSystemTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "./subversion_file_system_test.py", line 32, in testListDir
    sorted(self._file_system.Read(['list/']).Get()['list/']))
AssertionError: ['dir/', 'file0.html', 'file1.html', 'file2.html', 'file3.html',
'file4.html', 'file5.html', 'file6.html'] != [u'.svn/', u'dir/', u'file0.html',
u'file1.html', u'file2.html', u'file3.html', u'file4.html', u'file5.html',
u'file6.html']

----------------------------------------------------------------------
Ran 3 tests in 0.003s

FAILED (failures=1)


Presubmit checks took 3.5s to calculate.

[commit-bot: I haz the power, 2012-07-23 17:29:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hebert.christopherj@chromium.org/10800...

[commit-bot: I haz the power, 2012-07-23 18:40:13]

Change committed as 147890