Issue 10800038: Declare password_data_count_ as int to match the return type of its

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10800038: Declare password_data_count_ as int to match the return type of its (Closed)

Created:
8 years, 5 months ago by wtc

Modified:
8 years, 5 months ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Declare password_data_count_ as int to match the return type of its getter method. R=rsleevi@chromium.org BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147541

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	crypto/mock_keychain_mac.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

https://chromiumcodereview.appspot.com/10800038/diff/1/crypto/mock_keychain_mac.h File crypto/mock_keychain_mac.h (right): https://chromiumcodereview.appspot.com/10800038/diff/1/crypto/mock_keychain_mac.h#newcode217 crypto/mock_keychain_mac.h:217: mutable int password_data_count_; The MockKeychain class doesn't use password_data_count_ ...

8 years, 5 months ago (2012-07-19 17:57:42 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/10800038/1

8 years, 5 months ago (2012-07-19 18:37:23 UTC) #3

commit-bot: I haz the power

8 years, 5 months ago (2012-07-19 20:01:03 UTC) #4

Try job failure for 10800038-1 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Expand Messages | Collapse Messages