runtime/vm/flow_graph_compiler_ia32.cc - Issue 10800037: New linear scan allocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 10800037: New linear scan allocator. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Kevin's comments Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_ia32.cc

diff --git a/runtime/vm/flow_graph_compiler_ia32.cc b/runtime/vm/flow_graph_compiler_ia32.cc

index c795cfc8e8e25d768f29ae40b8269693cbfab52c..15761b3c4210d39e308eeac76e768f2e171a7ff1 100644

--- a/runtime/vm/flow_graph_compiler_ia32.cc

+++ b/runtime/vm/flow_graph_compiler_ia32.cc

@@ -49,9 +49,10 @@ void DeoptimizationStub::GenerateCode(FlowGraphCompiler* compiler) {

if (loc.IsInvalid()) {

ASSERT(values[i]->IsConstant());

__ PushObject(values[i]->AsConstant()->value());

- } else {

- ASSERT(loc.IsRegister());

+ } else if (loc.IsRegister()) {

__ pushl(loc.reg());

+ } else {

+ compiler->Bailout("unsupported deoptimization state");

}

« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_compiler_x64.cc » ('j') | no next file with comments »