Issue 10800033: Append to descriptors over map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10800033: Append to descriptors over map. (Closed)

Created:
8 years, 5 months ago by Toon Verwaest

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Append to descriptors over map. Committed: https://code.google.com/p/v8/source/detail?r=12141

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -74 lines)			Patch
M	src/bootstrapper.cc	View	17 chunks	+63 lines, -62 lines	0 comments	Download
M	src/factory.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View	3 chunks	+13 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL. Part of project redirect all descriptor changes over map.

8 years, 5 months ago (2012-07-19 09:06:05 UTC) #1

Jakob Kummerow

8 years, 5 months ago (2012-07-19 09:55:13 UTC) #2

LGTM.

For the record: according to our offline discussion, the reason for moving
descriptors->SetLastAdded(new_last_added); to Map::AppendDescriptor() is that
the last_added field will soon move from the DescriptorArray into the Map.

Expand Messages | Collapse Messages