lib/compiler/implementation/scanner/partial_parser.dart - Issue 10800027: Fixed tests so they do indeed confirm that values on optional named parameters are not allowed. Add…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/scanner/partial_parser.dart

Issue 10800027: Fixed tests so they do indeed confirm that values on optional named parameters are not allowed. Add… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/scanner/parser.dart ('k') | tests/language/named_parameters6_negative_test.dart » ('j') | tests/language/named_parameters6_negative_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/scanner/partial_parser.dart

diff --git a/lib/compiler/implementation/scanner/partial_parser.dart b/lib/compiler/implementation/scanner/partial_parser.dart

index 2199ddef8c6bdf8239b9c0764a0e17d96ad9cf9c..14f18efb51eb4fb9f94a960c227d0b0f8c2d72a2 100644

--- a/lib/compiler/implementation/scanner/partial_parser.dart

+++ b/lib/compiler/implementation/scanner/partial_parser.dart

@@ -90,7 +90,7 @@ class PartialParser extends Parser {

return token;

}

- Token parseFormalParameters(Token token) => skipFormals(token);

+ Token parseFormalParameters(Token token, [bool allowValuesForNamedOptionalParams = true]) => skipFormals(token);

Token skipFormals(Token token) {

listener.beginOptionalFormalParameters(token);