Fixed tests so they do indeed confirm that values on optional named parameters are not allowed. Add…

lib/compiler/implementation/scanner/parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * An event generating parser of Dart programs. This parser expects
  * all tokens in a linked list (aka a token stream).
  *
  * The class [Scanner] is used to generate a token stream. See the
  * file scanner.dart.
@@ skipping 51 matching lines @@
   Token parseInterfaceBody(Token token) {
     return parseClassBody(token);
   }
 
   Token parseNamedFunctionAlias(Token token) {
     Token typedefKeyword = token;
     listener.beginFunctionTypeAlias(token);
     token = parseReturnTypeOpt(token.next);
     token = parseIdentifier(token);
     token = parseTypeVariablesOpt(token);
-    token = parseFormalParameters(token);
+    token = parseFormalParameters(token, DISALLOW_VALUES_FOR_NAMED_OPTIONAL_PARAMS);
     listener.endFunctionTypeAlias(typedefKeyword, token);
     return expect(';', token);
   }
 
   Token parseReturnTypeOpt(Token token) {
     if (token.stringValue === 'void') {
       listener.handleVoidKeyword(token);
       return token.next;
     } else {
       return parseTypeOpt(token);
     }
   }
 
-  Token parseFormalParameters(Token token) {
+  final bool DISALLOW_VALUES_FOR_NAMED_OPTIONAL_PARAMS = false;
+  Token parseFormalParameters(Token token, [bool allowValuesForNamedOptionalParams = true]) {
     Token begin = token;
     listener.beginFormalParameters(begin);
     expect('(', token);
     int parameterCount = 0;
     if (optional(')', token.next)) {
       listener.endFormalParameters(parameterCount, begin, token.next);
       return token.next.next;
     }
     do {
       ++parameterCount;
       token = token.next;
       if (optional('[', token)) {
-        token = parseOptionalFormalParameters(token);
+        token = parseOptionalFormalParameters(token, allowValuesForNamedOptionalParams);
         break;
       }
-      token = parseFormalParameter(token);
+      token = parseFormalParameter(token, allowValuesForNamedOptionalParams);
     } while (optional(',', token));
     listener.endFormalParameters(parameterCount, begin, token);
     return expect(')', token);
   }
 
-  Token parseFormalParameter(Token token) {
+  Token parseFormalParameter(Token token, bool allowValuesForNamedOptionalParams) {
     listener.beginFormalParameter(token);
     token = parseModifiers(token);
     // TODO(ahe): Validate that there are formal parameters if void.
     token = parseReturnTypeOpt(token);
     Token thisKeyword = null;
     if (optional('this', token)) {
       thisKeyword = token;
       // TODO(ahe): Validate field initializers are only used in
       // constructors, and not for function-typed arguments.
       token = expect('.', token.next);
     }
     token = parseIdentifier(token);
     if (optional('(', token)) {
-      token = parseFormalParameters(token);
+      token = parseFormalParameters(token, DISALLOW_VALUES_FOR_NAMED_OPTIONAL_PARAMS);
       listener.handleFunctionTypedFormalParameter(token);
     }
     if (optional('=', token)) {
+      if (!allowValuesForNamedOptionalParams) {
+        listener.recoverableError("parameter must not specify a default value", token: token);
+      }
+
       // TODO(ahe): Validate that these are only used for optional parameters.
       Token equal = token;
       token = parseExpression(token.next);
       listener.handleValuedFormalParameter(equal, token);
     }
     listener.endFormalParameter(token, thisKeyword);
     return token;
   }
 
-  Token parseOptionalFormalParameters(Token token) {
+  Token parseOptionalFormalParameters(Token token, bool allowValuesForNamedOptionalParams) {
     Token begin = token;
     listener.beginOptionalFormalParameters(begin);
     assert(optional('[', token));
     int parameterCount = 0;
     do {
       token = token.next;
-      token = parseFormalParameter(token);
+      token = parseFormalParameter(token, allowValuesForNamedOptionalParams);
       ++parameterCount;
     } while (optional(',', token));
     listener.endOptionalFormalParameters(parameterCount, begin, token);
     return expect(']', token);
   }
 
   Token parseTypeOpt(Token token) {
     String value = token.stringValue;
     if (value === 'var') return parseType(token);
     if (value !== 'this') {
@@ skipping 1561 matching lines @@
     }
     listener.handleContinueStatement(hasTarget, continueKeyword, token);
     return expectSemicolon(token);
   }
 
   Token parseEmptyStatement(Token token) {
     listener.handleEmptyStatement(token);
     return expectSemicolon(token);
   }
 }