Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 10800026: Save PP_CompletionCallback in ppb_talk_private_thunk.cc (Closed)

Created:
8 years, 5 months ago by Josh Horwich
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Save PP_CompletionCallback in ppb_talk_private_thunk.cc Fix regression in tracking a PP_CompletionCallback in talk's GetPermission BUG=137952 TEST=Manual, attempt screenshare in gtalk Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147470

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ppapi/thunk/ppb_talk_private_thunk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Josh Horwich
Please take a look
8 years, 5 months ago (2012-07-19 00:55:40 UTC) #1
noahric
lgtm
8 years, 5 months ago (2012-07-19 00:56:57 UTC) #2
dmichael (off chromium)
lgtm
8 years, 5 months ago (2012-07-19 02:12:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhorwich@chromium.org/10800026/1
8 years, 5 months ago (2012-07-19 16:37:11 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 17:34:14 UTC) #5
Change committed as 147470

Powered by Google App Engine
This is Rietveld 408576698